Opened on 03/20/2015 at 11:45:03 AM

Closed on 04/02/2015 at 02:00:54 PM

#2187 closed change (fixed)

Drop class rietveld::private in favor of function hiera()

Reported by: matze Assignee: matze
Priority: P4 Milestone:
Module: Infrastructure Keywords:
Cc: fhd Blocked By: #2185
Blocking: #2182 Platform: Unknown
Ready: yes Confidential: no
Tester: Verified working: no
Review URL(s):

​http://codereview.adblockplus.org/6703666383814656/

Description

With the integration of Hiera (#112), class rietveld::private can be replaced by hiera() function calls within class rietveld, which isa way cleaner approach..

Attachments (0)

Change History (5)

comment:1 Changed on 03/20/2015 at 11:46:42 AM by matze

  • Blocked By 2185 added

Ticket #2185 will render $rietveld::private::admin_password obsolete.

comment:2 Changed on 03/20/2015 at 12:54:13 PM by matze

  • Cc fhd added
  • Review URL(s) modified (diff)

comment:3 Changed on 03/22/2015 at 12:19:24 AM by matze

  • Review URL(s) modified (diff)

comment:4 Changed on 03/22/2015 at 09:27:23 AM by matze

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:5 Changed on 04/02/2015 at 02:00:54 PM by matze

  • Resolution set to fixed
  • Status changed from reviewing to closed
  • Verified working unset

​https://hg.adblockplus.org/infrastructure/rev/4c9f503be1c2

Add Comment

Modify Ticket

Change Properties
Action
as closed .
The resolution will be deleted. Next status will be 'reopened'.
to The owner will be changed from matze.
Attachments ↑ Description ↑
 
Note: See TracTickets for help on using tickets.