Opened 5 years ago

Closed 5 years ago

Last modified 5 years ago

#1032 closed change (fixed)

Use the referrer mapping API from libadblockplus

Reported by: fhd Assignee:
Priority: P2 Milestone: Adblock-Plus-1.2-for-Internet-Explorer
Module: Adblock-Plus-for-Internet-Explorer Keywords:
Cc: Blocked By: #984
Blocking: #120 Platform: Internet Explorer
Ready: yes Confidential: no
Tester: Verified working: no
Review URL(s):

http://codereview.adblockplus.org/6321034575740928/

Description

Background

With #984, libadblockplus will get an API for building a chain of referrers for specific URLs. This is necessary for domain-based whitelisting to work within nested frames on platforms where we don't have any way to figure out the real frame structure.

What to change

Call ReferrerMapping::Add for each request and pass the result of ReferrerMapping::BuildReferrerChain to the respective FilterEngine::Matches call.

Change History (4)

comment:1 Changed 5 years ago by fhd

  • Blocking 120 added

comment:2 Changed 5 years ago by oleksandr

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:3 Changed 5 years ago by oleksandr

  • Resolution set to fixed
  • Status changed from reviewing to closed

comment:4 Changed 5 years ago by trev

  • Milestone set to Adblock-Plus-for-Internet-Explorer-1.2
Note: See TracTickets for help on using tickets.