Opened 5 years ago

Closed 5 years ago

#1048 closed change (fixed)

Generate Android update manifests in the libadblockplus format

Reported by: fhd Assignee: fhd
Priority: P2 Milestone:
Module: Infrastructure Keywords:
Cc: trev Blocked By: #1049
Blocking: #98 Platform: Unknown
Ready: yes Confidential: no
Tester: Verified working: no
Review URL(s):

http://codereview.adblockplus.org/6723860867055616/
http://codereview.adblockplus.org/5662610418565120/
http://codereview.adblockplus.org/6349778342379520/
http://codereview.adblockplus.org/5764619314397184/

Description (last modified by fhd)

Background

Android update checks are still using the old format, not the one used by libadblockplus (see #98).

What to change

Generate libadblockplus update manifests for Android on update.adblockplus.org.

Note that we need to keep generating updates.xml and androidupdates.xml for the foreseeable future - old versions of the app will still request those.

Change History (10)

comment:1 Changed 5 years ago by trev

  • Blocked By 44 added
  • Cc trev added

comment:2 Changed 5 years ago by fhd

  • Blocking 98 added

comment:3 Changed 5 years ago by fhd

  • Description modified (diff)
  • Priority changed from P3 to P2

comment:4 Changed 5 years ago by fhd

  • Blocked By 1049 added; 44 removed
  • Description modified (diff)
  • Summary changed from Move Android updates checks to update.adblockplus.org to Generate Android update manifests in the libadblockplus format

comment:5 Changed 5 years ago by fhd

  • Owner set to fhd

comment:6 Changed 5 years ago by fhd

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:7 Changed 5 years ago by fhd

  • Review URL(s) modified (diff)

comment:8 Changed 5 years ago by fhd

  • Review URL(s) modified (diff)

Pushed both patches, but it turns out the update.json format those generate is wrong. Here's how it looks currently:

[
  {
    "minSdkVersion": "7",
    "updateURL": "https://downloads.adblockplus.org/adblockplusandroid-1.2.1.apk?update",
    "revision": "318"
  }
]

Here's how it needs to look to work with the libadblockplus update mechanism:

{
  "adblockplusandroid": {
    "url": "https://downloads.adblockplus.org/adblockplusandroid-1.2.1.apk?update",
    "version": "1.2.1"
  }
}

Note that we will actually be working with the version then, instead of the revision. Also note that minSdkVersion would be ignored by the libadblockplus update mechanism, so I'm not adding it.

Adding a review that addresses this.

comment:9 Changed 5 years ago by fhd

  • Review URL(s) modified (diff)

Another review - sorry for the mess. We also need to generate devbuild update manifests in the new format.

comment:10 Changed 5 years ago by fhd

  • Resolution set to fixed
  • Status changed from reviewing to closed
Note: See TracTickets for help on using tickets.