Opened 5 years ago

Closed 5 years ago

Last modified 5 years ago

#1050 closed change (fixed)

Create utils project with shared files

Reported by: sergz Assignee: sergz
Priority: P4 Milestone: Adblock-Plus-1.2-for-Internet-Explorer
Module: Adblock-Plus-for-Internet-Explorer Keywords:
Cc: Blocked By:
Blocking: Platform: Internet Explorer
Ready: no Confidential: no
Tester: Verified working: no
Review URL(s):

http://codereview.adblockplus.org/5979045791531008/

Description

Background

Previously they were included into each project.

Some benefits from it:

  • DRY, it's already used by AdblockPlus, AdblockplusEngine and by tests
  • Less compilation time.
  • Theoretically it can happen that in tests there are some defines which change the code. Linking the same library we have the tested code.
  • No repeating - less disorder.
  • Also one have to be sure that it's compilable in all projects instead of in only one.

What to change

The gyp file from which the project is generated.

Change History (3)

comment:1 Changed 5 years ago by sergz

  • Component changed from Unknown to Adblock-Plus-for-Internet-Explorer
  • Owner set to sergz
  • Priority changed from Unknown to P4
  • Review URL(s) modified (diff)

comment:2 Changed 5 years ago by sergz

  • Resolution set to fixed
  • Status changed from new to closed

comment:3 Changed 5 years ago by trev

  • Milestone set to Adblock-Plus-for-Internet-Explorer-1.2
Note: See TracTickets for help on using tickets.