Opened 5 years ago

Closed 5 years ago

Last modified 4 years ago

#1088 closed defect (duplicate)

$document, $elemhide and element hiding exceptions don't fully cancel hiding rules

Reported by: Crits Assignee:
Priority: P2 Milestone:
Module: Adblock-Plus-for-Firefox Keywords:
Cc: mapx Blocked By:
Blocking: Platform: Firefox
Ready: no Confidential: no
Tester: Verified working: no
Review URL(s):

Description (last modified by Crits)

Environment

Firefox 30.0 (tested with fresh profile)
Adblock Plus 2.6.3.3849 (only enabled add-on in FF)
No subscription, only one filter : ##.ad_item

How to reproduce

  1. Add one of the following filter:
    @@||myhouseabroad.com^$document
    @@||myhouseabroad.com^$elemhide
    #@#.ad_item
    myhouseabroad.com#@#.ad_item
    
  2. Go to http://www.myhouseabroad.com/en/search/Luxury_Real_Estate.html

Observed behaviour

Display is broken, the "View" and "Save" buttons are too high (see attached file Broken display.jpg)

Expected behaviour

See attached file Normal display.jpg. This normal behaviour can be obtained by either disabling Adblock Plus everywhere or removing ##.ad_item

Note that with ABP enabled with just ##.ad_item and no exception rules, the Real Estate ads are actually completely hidden. Thus, the exception rules have indeed some effect but not the desired one.

The website owner might modify the classes of some of the website elements to circumvent this problem, if it is the case note that the elements whose classes are currently ad_item are located right after <!-- LIST ADS --> in the page source code.

Attachments (2)

Broken display.JPG (36.8 KB) - added by Crits 5 years ago.
Normal display.JPG (37.7 KB) - added by Crits 5 years ago.

Download all attachments as: .zip

Change History (8)

Changed 5 years ago by Crits

Changed 5 years ago by Crits

comment:1 Changed 5 years ago by Crits

  • Description modified (diff)

comment:2 Changed 5 years ago by mapx

  • Cc mapx added
  • Priority changed from Unknown to P2

comment:4 in reply to: ↑ 3 Changed 5 years ago by Crits

Replying to barbaz:

https://issues.adblockplus.org/ticket/521

Well found, reading the comments from arthur and trev it seems it would be fixed by #521

comment:5 Changed 5 years ago by Crits

  • Resolution set to duplicate
  • Status changed from new to closed

comment:6 Changed 4 years ago by philll

  • Platform changed from Firefox/Firefox Mobile to Firefox

Made Firefox and Firefox mobile available as seperate platforms.

Note: See TracTickets for help on using tickets.