Opened 5 years ago

Closed 5 years ago

Last modified 5 years ago

#1099 closed change (fixed)

Move away from yoda conditions in PluginUserSettings

Reported by: oleksandr Assignee: Mailkov
Priority: P4 Milestone: Adblock-Plus-for-Internet-Explorer-1.4
Module: Adblock-Plus-for-Internet-Explorer Keywords: goodfirstbug
Cc: Blocked By:
Blocking: Platform: Internet Explorer
Ready: yes Confidential: no
Tester: Verified working: no
Review URL(s):

Description

Change the conditions in PluginUserSettings.cpp to bo of type:
if (X != 0)
not like it is now:
if (0 != X)

Change History (9)

comment:1 Changed 5 years ago by oleksandr

  • Keywords goodfirstbug added

comment:2 Changed 5 years ago by Mailkov

I would like to work on this change

Last edited 5 years ago by Mailkov (previous) (diff)

comment:3 Changed 5 years ago by oleksandr

  • Owner set to Mailkov

Great!

comment:5 Changed 5 years ago by Mailkov

I think that it's now all fixed

comment:6 Changed 5 years ago by Mailkov

Change pull request now is https://github.com/adblockplus/adblockplusie/pull/5
can you merge? Thank's

Last edited 5 years ago by Mailkov (previous) (diff)

comment:7 Changed 5 years ago by Mailkov

Can you close this issue? Thank's

comment:8 Changed 5 years ago by oleksandr

  • Resolution set to fixed
  • Status changed from new to closed

Sure. Thank you!

comment:9 Changed 5 years ago by oleksandr

  • Milestone set to Adblock-Plus-for-Internet-Explorer-1.4
Note: See TracTickets for help on using tickets.