Opened 5 years ago

Closed 4 years ago

#1107 closed change (fixed)

Support notifications

Reported by: fhd Assignee: sergz
Priority: P3 Milestone:
Module: Libadblockplus Keywords:
Cc: jobp, fhd Blocked By:
Blocking: Platform: Unknown
Ready: yes Confidential: no
Tester: Unknown Verified working: no
Review URL(s):

http://codereview.adblockplus.org/5797488346791936/
http://codereview.adblockplus.org/4904655779790848/

Description (last modified by fhd)

Background

Adblock Plus supports notifications on most platforms. libadblockplus should also support this.

What to change

Regularly download notifications and decide which ones to show. We can either implement this as a function called by the client or as a callback.

Note that the notification download should only happen if clients are actually interested in notifications, similar to how updating works.

Change History (13)

comment:1 Changed 5 years ago by fhd

  • Blocking 1108 added

comment:2 Changed 5 years ago by fhd

  • Blocking 1109 added

comment:3 Changed 5 years ago by fhd

  • Description modified (diff)

comment:4 Changed 5 years ago by jobp

  • Blocking 1790 added

comment:5 Changed 5 years ago by sergz

  • Owner set to sergz

comment:6 Changed 5 years ago by sergz

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:7 Changed 5 years ago by jobp

  • Cc jobp added

comment:8 Changed 5 years ago by sergz

  • Review URL(s) modified (diff)

comment:9 Changed 5 years ago by sergz

  • Cc fhd added

I would like to precise here whether we need question notification listeners in libadblockplus or not.
First of all I guess it could be inconvenient for the libadlockplus client to fiddle around with our listeners and it might be merely an additional work for the client. In addition there is a technical reason, the user does not know and cannot predict the ID of the notification as well as there is no official way to to obtain it (since there is no Notification::GetID).
So, my suggestion is leave it up to the libadblockplus client. Your thoughts?

comment:10 Changed 5 years ago by jobp

  • Blocking 1790 removed

comment:11 Changed 5 years ago by rjeschke

  • Blocking 1108 removed

comment:12 Changed 4 years ago by sergz

  • Blocking 1109 removed

comment:13 Changed 4 years ago by sergz

  • Resolution set to fixed
  • Status changed from reviewing to closed
  • Tester set to Unknown
Note: See TracTickets for help on using tickets.