Opened 5 years ago

Closed 21 months ago

#1117 closed defect (rejected)

User able to send an issue report on invalid email

Reported by: passbrains Assignee:
Priority: P4 Milestone:
Module: Adblock-Plus-for-Firefox Keywords:
Cc: mapx Blocked By:
Blocking: Platform: Firefox
Ready: yes Confidential: no
Tester: Verified working: no
Review URL(s):

Description (last modified by trev)

Adapted from https://www.passbrains.com/dashboard/view-ticket.php?ticket_no=ARE-1

Environment

Windows XP 32bit Firefox English
ABP version 1.8.3.1204

How to reproduce

  1. Install Adblock 1.8.3.1204 into Firefox 31.0
  2. Open any website (e.g http://photo.net)
  3. Click on ABP icon and then on 'Report issue on this page...' label
  4. Choose the type of reported issue
  5. Click on Next button two times
  6. Enter invalid email into Email field  (e.g '1')
  7. Click on Send report button, observe the message "Your report has been saved..."

Observed behaviour

User able to send an issue report on invalid email.

Expected behaviour

User able to send an issue report only on valid email.

Attachments (1)

3469_1406070581_2_1.mp4 (1.3 MB) - added by passbrains 5 years ago.

Download all attachments as: .zip

Change History (7)

Changed 5 years ago by passbrains

comment:1 Changed 5 years ago by trev

  • Component changed from Unknown to Adblock-Plus-for-Firefox
  • Description modified (diff)
  • Priority changed from Unknown to P4
  • Ready set

We aren't too strict about data validation in the issue reporter, that's why we didn't bother validating the email addresses. However, now that the email address is mandatory, it makes sense to have minimal validation here - simply adding type="email" will do. We merely need to ensure that the user cannot continue if the email address is invalid.

comment:2 Changed 5 years ago by mapx

1.8.3.1204 is the last dev build for chrome

comment:3 Changed 5 years ago by mapx

  • Cc mapx added

comment:4 Changed 5 years ago by philll

I asked the tester to hand in the correct number.

comment:5 Changed 4 years ago by philll

  • Platform changed from Firefox/Firefox Mobile to Firefox

Made Firefox and Firefox mobile available as seperate platforms.

comment:6 Changed 21 months ago by trev

  • Resolution set to rejected
  • Status changed from new to closed

Mass-closing all bugs in Adblock Plus for Firefox module, the codebase of Adblock Plus 3.0 belongs into Platform and User-Interface modules. Old bugs are unlikely to still apply.

Note: See TracTickets for help on using tickets.