Opened 3 years ago

Closed 12 months ago

Last modified 9 months ago

#1121 closed defect (fixed)

Long filter texts get cut off in options page

Reported by: passbrains Assignee: wspee
Priority: P4 Milestone: Adblock-Plus-1.13-for-Chrome-Opera
Module: User-Interface Keywords: goodfirstbug
Cc: mapx, sven Blocked By:
Blocking: Platform: Chrome
Ready: yes Confidential: no
Tester: Ross Verified working: yes
Review URL(s):

https://codereview.adblockplus.org/29366984/

Description (last modified by greiner)

Adapted from https://www.passbrains.com/dashboard/view-ticket.php?ticket_no=ACH-12

Environment

Windows 7 64bit Chrome English
ABP version 1.8.3.1204

How to reproduce

  1. Add the following custom filter

guasgdfigifiuseuisfiuguiefasiulefsuifsefiausefiusefiuasieufasuiefasefialisuefisufalsiefsefhsidfhsoidfgsdf

Observed behaviour

The filter text gets cut off

Expected behaviour

The full filter text should be shown in the custom filter list

What to change

Add the style overflow: auto to the options page element select#userFiltersBox.

Attachments (1)

207_1406093120_TextCutOff.jpg (101.1 KB) - added by passbrains 3 years ago.

Download all attachments as: .zip

Change History (11)

Changed 3 years ago by passbrains

comment:1 Changed 3 years ago by mapx

  • Cc mapx added
  • Description modified (diff)

comment:2 Changed 3 years ago by sebastian

  • Cc sven added
  • Component changed from Unknown to User-Interface

I agree that the UI isn't great. However IMO, wrapping long filters into multiple linesm, would make it even harder to use with the current design. I hope sven comes up with a smart way to edit filters with the new UI.

comment:3 Changed 3 years ago by greiner

  • Priority changed from Unknown to P4

We might be able to use a horizontal scrollbar on the element for that but styling <option> tags is tricky so we may even need to create a custom element for that. Therefore I'm setting the priority to P4.

comment:4 Changed 3 years ago by greiner

  • Description modified (diff)
  • Ready set
  • Summary changed from Text gets cut off if the path of the blocked element is too long to Long filter texts get cut off in options page

comment:5 Changed 3 years ago by greiner

  • Keywords goodfirstbug added

comment:6 Changed 13 months ago by wspee

  • Owner set to wspee
  • Tester set to Unknown

comment:7 Changed 13 months ago by wspee

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:8 Changed 12 months ago by abpbot

comment:9 Changed 12 months ago by wspee

  • Milestone set to Adblock-Plus-for-Chrome-Opera-next
  • Resolution set to fixed
  • Status changed from reviewing to closed

comment:10 Changed 9 months ago by Ross

  • Tester changed from Unknown to Ross
  • Verified working set

Done. But doesn't appear in Safari/FF WebEx installs (opened as #4987).

ABP 1.12.4.1739
Chrome 49 / 56 / Windows 10
Chrome 56 / OS X 10.12
Chrome 56 / Ubuntu 16.04
Opera 37 / 41 / Windows 7
Safari 10 / OS X 10.12

Note: See TracTickets for help on using tickets.