Changes between Initial Version and Version 1 of Ticket #1122, comment 4


Ignore:
Timestamp:
09/03/2014 11:58:58 AM (5 years ago)
Author:
saroyanm
Comment:

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #1122, comment 4

    initial v1  
    1 This issue is appears because "page.sendMessage" method which in case of Chrome uses chrome.tabs.sendMessage API, is sending the message to all content scripts of the page which also include content scripts loaded into iframes, in include.postload we change the state of clickHide_activated boolean variable (which indicates whether we should show cancel button for block dialog in popup) after closing block dialog only in the content script of frame where it's loaded, looks like the top frame and so in the popup.js after calling "page.sendMessage" with type of get-clickhide-state we always getting the state of clickHide_activated variable of random content script in the page, so most likely that this issue will persist on pages that contains lot of iframes. 
     1This issue is appears because "page.sendMessage" method which in case of Chrome uses chrome.tabs.sendMessage API, is sending the message to all content scripts of the page which also include content scripts loaded into iframes, in include.postload we change the state of clickHide_activated boolean variable (which indicates whether we should show cancel button for block dialog in popup) after closing block dialog only in the content script of frame where it's loaded, looks like the top frame and so in the popup.js after calling "page.sendMessage" with type of get-clickhide-state we always getting the state of clickHide_activated variable of random content script (not sure in which order message to content scripts of the page is sent) in the page, so most likely that this issue will persist on pages that contains lot of iframes.