Opened 5 years ago

Closed 5 years ago

Last modified 5 years ago

#1128 closed change (fixed)

ADC logo/icon added to acceptableads.org

Reported by: ben Assignee: greiner
Priority: P3 Milestone:
Module: Websites Keywords: manifesto
Cc: sven, greiner, innerself, trev Blocked By:
Blocking: #1240 Platform: Unknown
Ready: yes Confidential: no
Tester: Verified working: no
Review URL(s):

http://codereview.adblockplus.org/5119431676002304/

Description (last modified by greiner)

Background

The Art Directors Club (ADC) would like to join the Acceptable Ads Manifesto on acceptableads.org

What to change

  • Insert ADC (logo is attached) in the signatories logos list between Adblock Plus and Auxilium Gaming Community
  • Hide Unwatch.Me in the signatories logos list
  • Add an "Additional organizations" link to the bottom-left of the signatories logos list which, when clicked, reveals organizations at the end of the list that are not shown by default (in this case it's only Unwatch.Me).

Attachments (2)

ADC_Logo_Final.pdf (229.4 KB) - added by ben 5 years ago.
adcglobal_45x45.png (18.7 KB) - added by sven 5 years ago.
Scaled adc global logo

Download all attachments as: .zip

Change History (15)

Changed 5 years ago by ben

Changed 5 years ago by sven

Scaled adc global logo

comment:1 Changed 5 years ago by greiner

Keep in mind that since #628 has now been closed there are already two rows of signatories which means that adding another icon would create a third row. Therefore we might want to wait for more organizations and design a new overflow mechanism to put them somewhere without overloading the page.

comment:2 Changed 5 years ago by ben

Yes, we definitely need a new overflow mechanism. I would recommend one that just says "Additional organizations" and displays all additional icons in rows when clicked. Since the top row should remain static, we should remove the last organization to sign up from the second row, i.e. Auxilium Gaming. That's the most fair way.

comment:3 Changed 5 years ago by sven

the suggestion by @ben is fine for me

comment:4 follow-up: Changed 5 years ago by greiner

Some remaining questions:

1) Should we wait for more organizations before tackling this?

2) Where should that link appear? At the same spot the "show all"/"hide all" link was located?

3) It sounds like you want them to be sorted chronologically by date of joining the manifesto from newest to oldest. Is that correct? If that's the case please provide the order they should appear in.

comment:5 in reply to: ↑ 4 ; follow-up: Changed 5 years ago by ben

Replying to greiner:

Some remaining questions:

1) Should we wait for more organizations before tackling this?
I don't think so. ADC is keen to be listed soon, and I don't see any reason to wait.

2) Where should that link appear? At the same spot the "show all"/"hide all" link was located?
Yeah, I think it makes sense there, i.e. right under the bottom-left icon.

3) It sounds like you want them to be sorted chronologically by date of joining the manifesto from newest to oldest. Is that correct? If that's the case please provide the order they should appear in.

Actually, if we always remove the newest signatory it could mean that organizations get bumped without having their icon displayed for very long. A better idea would be to remove the oldest signatory from the second row whenever someone new joins. So we should remove Unwatch.me, shift all remaining second-row icons right and fill the bottom-left spot with ADC.

However, I would reserve the right to keep new signatories listed in the second row longer if they contribute something to the project. Like ADC, which has agreed to promoting the Manifesto to its members.

comment:6 in reply to: ↑ 5 Changed 5 years ago by greiner

  • Description modified (diff)
  • Priority changed from Unknown to P3

Replying to ben:

I don't think so. ADC is keen to be listed soon, and I don't see any reason to wait.

The reason is that only a single organization would be shown after clicking on the "Additional organizations" link. But if we can agree on this not being an actual issue then we can ignore that.

However, I would reserve the right to keep new signatories listed in the second row longer if they contribute something to the project.

That's fine as long as the position is specified where exactly the logo should be inserted.

comment:7 Changed 5 years ago by ben

What's the status on this? I would like to let them know soon that their icon is up if there are no outstanding issues/unanswered questions.

comment:8 Changed 5 years ago by greiner

  • Owner set to greiner
  • Ready set

comment:9 Changed 5 years ago by greiner

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:10 Changed 5 years ago by trev

  • Resolution set to fixed
  • Status changed from reviewing to closed

comment:11 Changed 5 years ago by trev

  • Cc trev added

comment:12 Changed 5 years ago by greiner

  • Blocking 1240 added

comment:13 Changed 5 years ago by trev

  • Component changed from Infrastructure to Websites
Note: See TracTickets for help on using tickets.