Opened 5 years ago

Closed 5 years ago

#1137 closed defect (fixed)

Wrong URLs in the IE devbuild update manifest

Reported by: fhd Assignee: fhd
Priority: P2 Milestone:
Module: Infrastructure Keywords:
Cc: Blocked By:
Blocking: Platform: Unknown
Ready: yes Confidential: no
Tester: Verified working: no
Review URL(s):

http://codereview.adblockplus.org/4998927141044224/

Description

The devbuild update manifest we currently generate looks like this:

{
  "adblockplusie/win64": {
    "url": "https://adblockplus.org/devbuilds/adblockplusie/adblockplusie-1.2.667.exe?update",
    "version": "1.2.667"
  },
  "adblockplusie/msie64": {
    "url": "https://adblockplus.org/devbuilds/adblockplusie/adblockplusie-1.2.667.exe?update",
    "version": "1.2.667"
  },
  "adblockplusie/msie32": {
    "url": "https://adblockplus.org/devbuilds/adblockplusie/adblockplusie-1.2.667.exe?update",
    "version": "1.2.667"
  },
  "adblockplusie/win32": {
    "url": "https://adblockplus.org/devbuilds/adblockplusie/adblockplusie-1.2.667.exe?update",
    "version": "1.2.667"
  }
}

Instead of pointing to the .exe files, we should point to the architecture specific .msi files.

While we're at it, we can also remove the win32 and win64 entries, they're not used anymore.

Change History (3)

comment:1 Changed 5 years ago by fhd

  • Owner set to fhd

comment:2 Changed 5 years ago by fhd

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:3 Changed 5 years ago by fhd

  • Resolution set to fixed
  • Status changed from reviewing to closed
Note: See TracTickets for help on using tickets.