#1146 closed defect (rejected)
Disable for all does not reload page
| Reported by: | passbrains | Assignee: | |
|---|---|---|---|
| Priority: | P3 | Milestone: | Adblock-Plus-for-Internet-Explorer-1.6 |
| Module: | Adblock-Plus-for-Internet-Explorer | Keywords: | |
| Cc: | oleksandr | Blocked By: | |
| Blocking: | Platform: | Internet Explorer | |
| Ready: | no | Confidential: | no |
| Tester: | Rraceanu | Verified working: | no |
| Review URL(s): | |||
Description (last modified by oleksandr)
Adapted from https://www.passbrains.com/dashboard/view-ticket.php?ticket_no=AIN-13
Environment
Windows 7 32bit Internet Explorer 11 English
ABP version 1.2.636.0
How to reproduce
- Open IE browser with installed Adblock
- Go to http://www.fotor.com/ with ad on the top that is currently blocked by Adblock
- Click on ABP icon -> Disable on www.fotor.com
-> page is reloaded and ad is now displayed as expected
- Click on Disable on www.fotor.com once again to hide ad
- Click on ABP icon and then 'Disable for all'
Observed behaviour
- Selecting 'Disable for all' option does not reload page that is currently opened like it is happening when we do a disable for specific page only.
- ABP icon is now grayed out like disabled
- Ad is not displayed on the page as expected when add-on is disabled
Expected behaviour
Page should be reloaded once the option is selected and ad should appear.
Attachments (1)
Change History (12)
Changed 5 years ago by passbrains
comment:1 Changed 5 years ago by oleksandr
- Component changed from Unknown to Adblock-Plus-for-Internet-Explorer
- Description modified (diff)
- Priority changed from Unknown to P3
- Ready set
comment:2 Changed 5 years ago by oleksandr
- Milestone set to Adblock-Plus-for-Internet-Explorer-1.4
comment:3 Changed 4 years ago by Mailkov
comment:4 Changed 4 years ago by philll
- Cc oleksandr added
- Ready unset
We actually regard automatic reloading as an undesired or at least questionable behaviour so far. Please see #1914 and the issues linked in there. I unset the ready state until we made a final decision on this general global topic.
comment:5 Changed 4 years ago by Mailkov
pull request https://github.com/adblockplus/adblockplusie/pull/12 with https://github.com/adblockplus/adblockplusie/pull/10 resolve the problem ... when you made a final decision ... :)
comment:6 Changed 4 years ago by Mailkov
I think is more logic an automatic reloading ...
comment:7 Changed 4 years ago by sergz
- Tester set to Unknown
We should reference here #1339, according to which it should not reload a page.
comment:8 Changed 4 years ago by eric@…
Given the resolution on #1339, I think we can close this ticket as rejected. Correct, @oleksandr?
comment:9 Changed 4 years ago by oleksandr
- Resolution set to rejected
- Status changed from new to closed
Right, we are now consistent and don't reload the page when blocking was enabled/disabled in any way.
comment:10 Changed 3 years ago by rraceanu
- Tester changed from Unknown to Rraceanu
- Verified working set
Invalid comment.
comment:11 Changed 3 years ago by rraceanu
- Verified working unset
I'd like to work on this