Opened 5 years ago

Closed 5 years ago

Last modified 5 years ago

#1148 closed defect (fixed)

ABP on chrome blocks ads but IE doesnt

Reported by: passbrains Assignee: sergz
Priority: P2 Milestone: Adblock-Plus-for-Internet-Explorer-1.3
Module: Adblock-Plus-for-Internet-Explorer Keywords:
Cc: Blocked By:
Blocking: Platform: Internet Explorer
Ready: yes Confidential: no
Tester: Verified working: no
Review URL(s):

http://codereview.adblockplus.org/6433575100481536/

Description (last modified by oleksandr)

Adapted from https://www.passbrains.com/dashboard/view-ticket.php?ticket_no=AIN-26

Environment

Windows 7 64bit Internet Explorer 8 English
ABP version 1.2.636

How to reproduce

  1. Install ABP for IE version 1.2.636 and ABP for Chrome version 1.8.3.1204.
  2. Launch link in both browsers

http://seattletimes.com/html/larrystone/2023753540_stone03xml.html

Observed behaviour

IE ABP doesnt block ads on that page.

Expected behaviour

IE ABP should also block ads like Chrome ABP

Attachments (2)

1618_1406123001_Chrome.PNG (51.0 KB) - added by passbrains 5 years ago.
1618_1406123001_IE.PNG (232.7 KB) - added by passbrains 5 years ago.

Download all attachments as: .zip

Change History (8)

Changed 5 years ago by passbrains

Changed 5 years ago by passbrains

comment:1 Changed 5 years ago by oleksandr

  • Component changed from Unknown to Adblock-Plus-for-Internet-Explorer
  • Description modified (diff)
  • Priority changed from Unknown to P2
  • Ready set

comment:2 Changed 5 years ago by oleksandr

  • Owner set to sergz

comment:3 Changed 5 years ago by sergz

The bug is in CFilterElementHide.

  • IHTMLElement::getAttribute sometimes returns not only BSTR or integer but also IDispatch. For example, for the tag like <some-tag on-some-event="do();"/> the value of on-some-event is IDispatch which toString() method returns function(event){\ndo();\n}. The selector in filter is ##a\[onmousedown^="this.href='http://paid.outbrain.com/network/redir?"]\[target="_blank"]
  • the selector ##a\[onmousedown^="this.href='http://paid.outbrain.com/network/redir?"]\[target="_blank"] + .ob_source is not properly applied
Last edited 5 years ago by sergz (previous) (diff)

comment:4 Changed 5 years ago by sergz

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:5 Changed 5 years ago by sergz

  • Resolution set to fixed
  • Status changed from reviewing to closed

comment:6 Changed 5 years ago by oleksandr

  • Milestone set to Adblock-Plus-for-Internet-Explorer-next
Note: See TracTickets for help on using tickets.