Opened 5 years ago

Closed 5 years ago

Last modified 4 years ago

#1155 closed change (fixed)

Don't allow displaying icon text with Australis theme

Reported by: trev Assignee: saroyanm
Priority: P4 Milestone: Customizations-1.0.4-for-Adblock-Plus
Module: Extensions-for-Adblock-Plus Keywords:
Cc: Blocked By:
Blocking: Platform: Firefox
Ready: yes Confidential: no
Tester: Verified working: no
Review URL(s):

http://codereview.adblockplus.org/4744516900749312

Description

Background

Recent Firefox versions introduced the Australis theme. This theme no longer supports displaying toolbar icons with text, switching on text display by means of Customization for Adblock Plus causes various display issues (see #1079).

What to change

Don't display "Toolbar item display" option in Customization for Adblock Plus when the Australis theme is active, keep it in older Firefox versions and SeaMonkey. We can check whether the resource:///modules/CustomizableUI.jsm module exists to see whether the Australis theme is active.

Change History (7)

comment:1 Changed 5 years ago by saroyanm

  • Owner set to saroyanm

comment:2 Changed 5 years ago by saroyanm

  • Owner saroyanm deleted

comment:3 Changed 5 years ago by saroyanm

  • Owner set to saroyanm

comment:4 Changed 5 years ago by saroyanm

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:5 Changed 5 years ago by saroyanm

  • Resolution set to fixed
  • Status changed from reviewing to closed

comment:6 Changed 5 years ago by trev

  • Milestone set to Customizations-for-Adblock-Plus-next

comment:7 Changed 4 years ago by philll

  • Platform changed from Firefox/Firefox Mobile to Firefox

Made Firefox and Firefox mobile available as seperate platforms.

Note: See TracTickets for help on using tickets.