Opened 5 years ago

Closed 5 years ago

Last modified 5 years ago

#1158 closed change (fixed)

Clean up predefines in plugin code

Reported by: oleksandr Assignee: eric@…
Priority: P4 Milestone: Adblock-Plus-for-Internet-Explorer-1.3
Module: Adblock-Plus-for-Internet-Explorer Keywords:
Cc: Blocked By:
Blocking: Platform: Internet Explorer
Ready: yes Confidential: no
Tester: Verified working: no
Review URL(s):

http://codereview.adblockplus.org/5948518908821504/

Description

Background

Currently we have stuff like in config.h
#if (defined PRODUCT_ADBLOCKPLUS)
#define SUPPORT_FILTER
#define SUPPORT_WHITELIST
#define SUPPORT_DOM_TRAVERSER
#define SUPPORT_FRAME_CACHING
#endif

But most of those predefines are not needed, as they are always defined.

What to change

Cleanup the predefines and only use the ones that are needed.

Change History (3)

comment:1 Changed 5 years ago by eric@…

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:2 Changed 5 years ago by oleksandr

  • Ready set
  • Resolution set to fixed
  • Status changed from reviewing to closed

comment:3 Changed 5 years ago by fhd

  • Milestone set to Adblock-Plus-for-Internet-Explorer-1.3
Note: See TracTickets for help on using tickets.