Opened 5 years ago

Last modified 5 years ago

#1164 new change

Check WBPassThrough for exception safety

Reported by: sergz Assignee:
Priority: P5 Milestone:
Module: Adblock-Plus-for-Internet-Explorer Keywords: WBPassThrough, IE
Cc: Blocked By:
Blocking: Platform: Internet Explorer
Ready: yes Confidential: no
Tester: Verified working: no
Review URL(s):

Description

Background

The hell of calls, especially from from different threads, in WbPassThrough looks very fragile, so to have at least something potentially harmful here looks very dangerous.
Also check that there is no non-optimal calls which can reduce the performance, undesired locks, cause any side-effects, and so on.

What to change

Currently noted that case http://codereview.adblockplus.org/5171515343503360/diff/6063544634179584/src/plugin/PluginWbPassThrough.cpp#newcode99

Change History (1)

comment:1 Changed 5 years ago by oleksandr

  • Ready set
Note: See TracTickets for help on using tickets.