Opened 5 years ago

Closed 5 years ago

Last modified 5 years ago

#1166 closed change (fixed)

Import strings from ABP for Firefox

Reported by: fhd Assignee: fhd
Priority: P1 Milestone: Adblock-Plus-1.2-for-Internet-Explorer
Module: Adblock-Plus-for-Internet-Explorer Keywords:
Cc: trev Blocked By:
Blocking: #1179 Platform: Internet Explorer
Ready: yes Confidential: no
Tester: Verified working: no
Review URL(s):

http://codereview.adblockplus.org/5748296123416576/

Description

Background

Since we have some of the same strings (particularly regarding Acceptable Ads), we should import them directly from Firefox.

What to change

We have something similar in Chrome already, it should work like that. buildtools/localeTools.py has a readFile function that can parse Firefox translation files.

Change History (5)

comment:1 Changed 5 years ago by fhd

  • Owner set to fhd

comment:2 Changed 5 years ago by fhd

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

What's still missing is the "Adblock Plus has been updated" text. We had that in Chrome, but it has been removed. We can retrieve the old translations from there.

comment:3 Changed 5 years ago by fhd

  • Blocking 1179 added

comment:4 Changed 5 years ago by fhd

  • Resolution set to fixed
  • Status changed from reviewing to closed

comment:5 Changed 5 years ago by fhd

  • Milestone set to Adblock-Plus-for-Internet-Explorer-1.2
Note: See TracTickets for help on using tickets.