Opened 5 years ago

Closed 4 years ago

#1184 closed change (fixed)

[meta] Installer cleanup

Reported by: fhd Assignee: eric@…
Priority: P2 Milestone:
Module: Adblock-Plus-for-Internet-Explorer Keywords: meta installer
Cc: Blocked By: #1185, #1186, #1187, #1984
Blocking: Platform: Internet Explorer
Ready: yes Confidential: no
Tester: Unknown Verified working: no
Review URL(s):

Description (last modified by fhd)

Background

The current installer code has been committed without review. We need to review the changes and create issues for all the things we need to clean up.

What to change

Ticket Status Resolution Summary Component Owner
#1185 closed fixed [Installer cleanup] Make code formatting and indentation comply with our coding style Adblock-Plus-for-Internet-Explorer eric@…
#1186 closed fixed [Installer cleanup] Make the naming comply with our coding style Adblock-Plus-for-Internet-Explorer eric@…
#1187 closed fixed [Installer cleanup] Do not leak MSIHANDLEs in custom action Adblock-Plus-for-Internet-Explorer eric@…
#1984 closed fixed Do not use VBScript in installer build tools Adblock-Plus-for-Internet-Explorer oleksandr


Change History (13)

comment:1 Changed 5 years ago by fhd

  • Description modified (diff)

comment:2 Changed 5 years ago by fhd

  • Blocked By 1185 added

comment:3 Changed 5 years ago by fhd

  • Blocked By 1186 added

comment:4 Changed 5 years ago by oleksandr

  • Blocked By 1187 added

comment:5 Changed 5 years ago by fhd

  • Blocked By 1189 added

comment:6 Changed 5 years ago by fhd

  • Keywords installer added

comment:7 Changed 5 years ago by fhd

  • Blocked By 1189 removed

comment:8 Changed 5 years ago by fhd

  • Priority changed from P3 to P2

Increasing priority - we should tackle this before the other installer issues.

comment:9 Changed 4 years ago by oleksandr

  • Milestone set to Adblock-Plus-for-Internet-Explorer-Next

comment:10 Changed 4 years ago by oleksandr

  • Owner set to eric@…

comment:11 Changed 4 years ago by oleksandr

  • Blocked By 1984 added

comment:12 Changed 4 years ago by oleksandr

  • Milestone Adblock-Plus-for-Internet-Explorer-1.4 deleted

comment:13 Changed 4 years ago by eric@…

  • Resolution set to fixed
  • Status changed from new to closed
  • Tester set to Unknown
Note: See TracTickets for help on using tickets.