Opened 5 years ago

Closed 4 years ago

Last modified 3 years ago

#1185 closed change (fixed)

[Installer cleanup] Make code formatting and indentation comply with our coding style

Reported by: fhd Assignee: eric@…
Priority: P2 Milestone: Adblock-Plus-for-Internet-Explorer-1.6
Module: Adblock-Plus-for-Internet-Explorer Keywords: installer
Cc: Blocked By:
Blocking: #1184 Platform: Internet Explorer
Ready: yes Confidential: no
Tester: Unknown Verified working: no
Review URL(s):

https://codereview.adblockplus.org/29329159/

Description (last modified by fhd)

Background

See #1184.

What to change

The installer specific code is pretty far from our coding style currently, we should make the code formatting consistent with it. The main issues seem to be spaces in parentheses and before semicolons, and sometimes tabs instead of spaces for indentation.

Change History (13)

comment:1 Changed 5 years ago by fhd

  • Description modified (diff)
  • Summary changed from [Installer cleanup] Fix indentation and whitespace issues to [Installer cleanup] Fix code formatting and indentation

comment:2 Changed 5 years ago by fhd

  • Summary changed from [Installer cleanup] Fix code formatting and indentation to [Installer cleanup] Make code formatting and indentation comply with our coding style

comment:3 Changed 5 years ago by eric@…

I've used Artistic Style to convert my personal coding style (that's what present in the code base now) to be more in conformance with the ABP style.
http://astyle.sourceforge.net/

One caveat. It doesn't handle spaces before and after square brackets.

comment:4 Changed 5 years ago by fhd

  • Blocking 1189 added

comment:5 Changed 5 years ago by fhd

  • Keywords installer added

comment:6 Changed 5 years ago by fhd

  • Blocking 1189 removed

comment:7 Changed 5 years ago by fhd

  • Priority changed from P3 to P2

Increasing priority - we should tackle this before the other installer issues.

comment:8 Changed 5 years ago by oleksandr

  • Milestone set to Adblock-Plus-for-Internet-Explorer-Next

comment:9 Changed 5 years ago by oleksandr

  • Owner set to eric@…

comment:10 Changed 5 years ago by oleksandr

  • Milestone Adblock-Plus-for-Internet-Explorer-1.4 deleted

comment:11 Changed 4 years ago by eric@…

  • Review URL(s) modified (diff)
  • Tester set to Unknown

comment:12 Changed 4 years ago by eric@…

  • Resolution set to fixed
  • Status changed from new to closed

comment:13 Changed 3 years ago by oleksandr

  • Milestone set to Adblock-Plus-for-Internet-Explorer-Next
Note: See TracTickets for help on using tickets.