Opened 5 years ago

Closed 4 years ago

Last modified 3 years ago

#1186 closed change (fixed)

[Installer cleanup] Make the naming comply with our coding style

Reported by: fhd Assignee: eric@…
Priority: P2 Milestone: Adblock-Plus-for-Internet-Explorer-1.6
Module: Adblock-Plus-for-Internet-Explorer Keywords: installer
Cc: Blocked By:
Blocking: #1184 Platform: Internet Explorer
Ready: yes Confidential: no
Tester: Unknown Verified working: no
Review URL(s):

http://codereview.adblockplus.org/5219280069066752/
https://codereview.adblockplus.org/5992177905696768/
https://codereview.adblockplus.org/29329510/

Description (last modified by fhd)

Background

See #1184.

What to change

The installer code is in general quite far from our [coding style](https://adblockplus.org/en/coding-style). Aside the formatting, naming is also both inconsistent within the installer and with our coding style. That needs to be fixed.

We should make the file naming comply with our conventions in the same step: Should be camel case, generally the name of the major namespace or class in that file.

Change History (15)

comment:1 Changed 5 years ago by fhd

  • Summary changed from [Installer cleanup] Fix naming to [Installer cleanup] Make the naming comply with our coding style

comment:2 Changed 5 years ago by fhd

  • Blocking 1184 added

comment:3 Changed 5 years ago by fhd

  • Blocking 1189 added

comment:4 Changed 5 years ago by fhd

  • Description modified (diff)

comment:5 Changed 5 years ago by fhd

  • Keywords installer added

comment:6 Changed 5 years ago by fhd

  • Blocking 1189 removed

comment:7 Changed 5 years ago by fhd

  • Priority changed from P3 to P2

Increasing priority - we should tackle this before the other installer issues.

comment:8 Changed 4 years ago by oleksandr

  • Milestone set to Adblock-Plus-for-Internet-Explorer-Next

comment:9 Changed 4 years ago by oleksandr

  • Owner set to eric@…

comment:10 Changed 4 years ago by eric@…

  • Owner changed from eric@… to eric@…
  • Review URL(s) modified (diff)

comment:11 Changed 4 years ago by oleksandr

  • Milestone Adblock-Plus-for-Internet-Explorer-1.4 deleted

comment:12 Changed 4 years ago by eric@…

  • Review URL(s) modified (diff)
  • Tester set to Unknown

comment:13 Changed 4 years ago by eric@…

  • Review URL(s) modified (diff)

comment:14 Changed 4 years ago by eric@…

  • Resolution set to fixed
  • Status changed from new to closed

comment:15 Changed 3 years ago by oleksandr

  • Milestone set to Adblock-Plus-for-Internet-Explorer-Next
Note: See TracTickets for help on using tickets.