Opened 5 years ago

Closed 4 years ago

Last modified 4 years ago

#1187 closed change (fixed)

[Installer cleanup] Do not leak MSIHANDLEs in custom action

Reported by: oleksandr Assignee: eric@…
Priority: P2 Milestone: Adblock-Plus-for-Internet-Explorer-1.4
Module: Adblock-Plus-for-Internet-Explorer Keywords: installer
Cc: oleksandr Blocked By: #1762
Blocking: #1184 Platform: Internet Explorer
Ready: yes Confidential: no
Tester: Verified working: no
Review URL(s):

http://codereview.adblockplus.org/5281597276291072/

Description

Background

Our installer custom action is leaking 2 MSIHANDLEs (as can be seen by the verbose install log).

What to change

Fix the leakage and close all MSIHANDLEs properly

Change History (9)

comment:1 Changed 5 years ago by oleksandr

  • Summary changed from [Installer cleanup] to [Installer cleanup] Do not leak MSIHANDLEs in custom action

comment:2 Changed 5 years ago by fhd

  • Keywords installer added

comment:3 Changed 5 years ago by fhd

  • Priority changed from Unknown to P2

Increasing priority - we should tackle this before the other installer issues.

comment:4 Changed 4 years ago by eric@…

I'm not getting the leakage message reliably under Windows 7. In some circumstances, it's not leaking at all. In others, it's leaking one handle. I haven't seen it leak two handles under any circumstances.

The differing circumstances that my be relevant include (1) Windows version, (2) installer version, release or devbuild, (3) whether IE is running at any point during installation, (4) if relevant, what the responses to the dialogs from the CloseIe custom action are.

Last edited 4 years ago by eric@… (previous) (diff)

comment:5 Changed 4 years ago by eric@…

  • Blocked By 1762 added

comment:6 Changed 4 years ago by eric@…

  • Owner set to eric@…
  • Review URL(s) modified (diff)

comment:7 Changed 4 years ago by eric@…

  • Status changed from new to reviewing

comment:8 Changed 4 years ago by eric@…

  • Resolution set to fixed
  • Status changed from reviewing to closed

comment:9 Changed 4 years ago by oleksandr

  • Milestone set to Adblock-Plus-for-Internet-Explorer-Next
Note: See TracTickets for help on using tickets.