Opened 3 years ago

Closed 8 months ago

#119 closed change (fixed)

Switch to injecting CSS for element hiding, falling back to traversal on older IE

Reported by: fhd Assignee: sergz
Priority: P3 Milestone: Adblock-Plus-for-Internet-Explorer-1.6
Module: Adblock-Plus-for-Internet-Explorer Keywords:
Cc: Blocked By: #1672, #1793
Blocking: #1642 Platform: Internet Explorer
Ready: yes Confidential: no
Tester: Unknown Verified working: no
Review URL(s):

http://codereview.adblockplus.org/6567422169448448/

Description (last modified by fhd)

Background

ABP for IE currently does DOM traversal for element hiding, which has a number of issues.

What to change

We should switch to injecting CSS, which is in line with what we do on all other platforms, plus it's faster and more maintainable.

However, we need to keep using the traverser on older IE versions with limited CSS selector support. We could go over each selector, check if the IE version could support it and handle it using the traverser otherwise. That way, a considerable amount of rules could still be handled via CSS injection.

Change History (15)

comment:1 Changed 3 years ago by philll

  • Owner set to fhd
  • Status changed from new to assigned

@fhd: Please add the required missing information and what "older IE" means exactly.

comment:2 Changed 3 years ago by fhd

  • Description modified (diff)
  • Priority changed from Unknown to P3
  • Reporter changed from philll to fhd
  • Status changed from assigned to accepted

comment:3 Changed 3 years ago by fhd

  • Owner fhd deleted
  • Status changed from accepted to assigned

comment:4 Changed 3 years ago by fhd

  • Status changed from assigned to accepted

comment:5 Changed 3 years ago by philll

  • Status changed from accepted to new

comment:6 Changed 3 years ago by oleksandr

  • Platform set to Unknown
  • Priority changed from P3 to P4
  • Ready unset

comment:7 Changed 3 years ago by oleksandr

  • Platform changed from Unknown to Internet Explorer

comment:8 Changed 3 years ago by oleksandr

  • Owner set to sergz

comment:9 Changed 3 years ago by sergz

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:10 Changed 3 years ago by sergz

  • Blocked By 1672, 1793 added

comment:11 Changed 3 years ago by oleksandr

  • Milestone set to Adblock-Plus-for-Internet-Explorer-Next
  • Priority changed from P4 to P3
  • Ready set

comment:12 Changed 2 years ago by sergz

  • Blocking 1642 added

comment:14 Changed 10 months ago by abpbot

A commit referencing this issue has landed:
Issue 119 - improve memory handling and improve code organizing

comment:15 Changed 8 months ago by oleksandr

  • Resolution set to fixed
  • Status changed from reviewing to closed
  • Tester set to Unknown
Note: See TracTickets for help on using tickets.