Opened 5 years ago

Closed 5 years ago

Last modified 5 years ago

#1196 closed change (fixed)

Fix dealing with boolean VARIANT

Reported by: sergz Assignee: sergz
Priority: P3 Milestone: Adblock-Plus-for-Internet-Explorer-1.3
Module: Adblock-Plus-for-Internet-Explorer Keywords:
Cc: Blocked By:
Blocking: Platform: Internet Explorer
Ready: yes Confidential: no
Tester: Verified working: no
Review URL(s):

http://codereview.adblockplus.org/6248869830590464/

Description

Background

In src/plugin/PluginUserSettings.cpp we set the value of variant by implicitly converting it from C++ bool to VARIANT_BOOL, which is wrong. In COM world we should use VARIANT_TRUE which is -1.

Change History (4)

comment:1 Changed 5 years ago by sergz

  • Resolution set to fixed
  • Status changed from new to closed

comment:2 Changed 5 years ago by trev

  • Milestone set to Adblock-Plus-for-Internet-Explorer-next

comment:3 Changed 5 years ago by fhd

  • Priority changed from Unknown to P4
  • Ready set

Posthumously setting priority and ready - P3 seems about appropriate here.

comment:4 Changed 5 years ago by fhd

  • Priority changed from P4 to P3

Since I said P3, I'll actually set P3 :)

Note: See TracTickets for help on using tickets.