Opened 6 years ago

Last modified 16 months ago

#119 closed change

Switch to injecting CSS for element hiding, falling back to traversal on older IE — at Version 2

Reported by: fhd Assignee: fhd
Priority: P3 Milestone: Adblock-Plus-for-Internet-Explorer-1.6
Module: Adblock-Plus-for-Internet-Explorer Keywords:
Cc: Blocked By:
Blocking: Platform: Internet Explorer
Ready: yes Confidential: no
Tester: Unknown Verified working: no
Review URL(s):

http://codereview.adblockplus.org/6567422169448448/

Description (last modified by fhd)

Background

ABP for IE currently does DOM traversal for element hiding, which has a number of issues.

What to change

We should switch to injecting CSS, which is in line with what we do on all other platforms, plus it's faster and more maintainable.

However, we need to keep using the traverser on older IE versions with limited CSS selector support. We could go over each selector, check if the IE version could support it and handle it using the traverser otherwise. That way, a considerable amount of rules could still be handled via CSS injection.

Change History (2)

comment:1 Changed 6 years ago by philll

  • Owner set to fhd
  • Status changed from new to assigned

@fhd: Please add the required missing information and what "older IE" means exactly.

comment:2 Changed 6 years ago by fhd

  • Description modified (diff)
  • Priority changed from Unknown to P3
  • Reporter changed from philll to fhd
  • Status changed from assigned to accepted
Note: See TracTickets for help on using tickets.