Opened 4 years ago

Last modified 4 years ago

#1221 new defect

Installing ABP 1.2 doesn't remove the old version

Reported by: Gingerbread Man Assignee:
Priority: P4 Milestone:
Module: Adblock-Plus-for-Internet-Explorer Keywords: installer
Cc: Blocked By:
Blocking: Platform: Internet Explorer
Ready: yes Confidential: no
Tester: Verified working: no
Review URL(s):

Description (last modified by oleksandr)

Environment

Me: Windows XP SP3 • Internet Explorer 8
Others: Windows 7 x64 SP1 • Internet Explorer 11

How to reproduce

  1. Run the installer for Adblock Plus 1.2 on a system that already has 1.1 installed.

Observed behavior

The version 1.1 isn't removed, or at least an entry is still listed in Control Panel.

Expected behavior

The version 1.1 should be removed and no uninstall entry for it should appear in Control Panel.

Forum thread

https://adblockplus.org/forum/viewtopic.php?f=16&t=24506

Attachments (1)

abpie_duplicate.png (6.8 KB) - added by Gingerbread Man 4 years ago.
abpie_duplicate.png

Download all attachments as: .zip

Change History (8)

Changed 4 years ago by Gingerbread Man

abpie_duplicate.png

comment:1 Changed 4 years ago by fhd

I've seen this too - ABP for IE is actually getting removed though, there's just a leftover entry from Burn. I'm not exactly sure if it would make sense to remove that via the MSI uninstallation.

comment:2 Changed 4 years ago by fhd

  • Keywords installer added

comment:3 Changed 4 years ago by eric@…

Given the way that burn works, it may well be easiest to use burn to remove that entry. We might be able to bundle a burn-based uninstaller for that rump entry into the InnoSetup packager.

Regardless, burn requires its own separate GUID, apart from the Product GUID that's in the MSI's. It's called UpgradeCode in the burn source. Nothing without that GUID there is going to (cleanly) uninstall that old entry.

comment:4 Changed 4 years ago by fhd

  • Priority changed from P2 to P3

Reducing priority - not critical enough for a P2.

comment:5 Changed 4 years ago by oleksandr

  • Priority changed from P3 to P4

To update this ticket: update from 1.2 to 1.3 *will* remove the previous version entry. It's only 1.1 leftovers that are not being cleaned up. Considering that, I am reducing priority even more.

comment:6 Changed 4 years ago by oleksandr

  • Ready set

comment:7 Changed 4 years ago by oleksandr

  • Description modified (diff)
Note: See TracTickets for help on using tickets.