Opened 6 years ago

Closed 4 years ago

#123 closed change (fixed)

Don't hard code the admin email address everywhere

Reported by: fhd Assignee: matze
Priority: P3 Milestone:
Module: Infrastructure Keywords:
Cc: fred Blocked By: #112, #3206
Blocking: Platform: Unknown
Ready: yes Confidential: no
Tester: Unknown Verified working: no
Review URL(s):

https://codereview.adblockplus.org/29329120/
https://codereview.adblockplus.org/29329128/
https://codereview.adblockplus.org/29329131/

Description

Background

We're currently hard coding the email address for the admins list (admins@…) all over our Puppet modules. This means that this list is receiving tons of pointless emails when someone is working with certain parts of the infrastructure locally.

What to change

We shouldn't hard code admins@… everywhere, it should be defined in one place. And furthermore, we shouldn't only use admins@… in production, and some dummy email address in the test environment. To achieve this, it probably makes sense to set the email address in the private module.

Change History (16)

comment:1 Changed 6 years ago by poz2k4444

I sent a pull request in github in this link:

https://github.com/adblockplus/infrastructure/pull/2

I pulled the last commit from the official mercurial repository to have the latest version in github.

comment:2 Changed 5 years ago by trev

  • Owner set to poz2k4444
  • Ready set
  • Status changed from new to assigned

comment:3 Changed 5 years ago by christian

  • Cc cvervoorts@… added

comment:4 Changed 5 years ago by poz2k4444

  • Review URL(s) modified (diff)

comment:5 Changed 5 years ago by poz2k4444

I couldn't rebase the git repo so I made another branch and a new pull request, the link is in the description

comment:6 Changed 5 years ago by philll

  • Status changed from assigned to new

The assigned state will be dropped by #403

comment:7 Changed 5 years ago by matze

  • Blocked By 112 added
  • Platform set to Unknown

comment:8 Changed 5 years ago by matze

With the integration of Hiera (see #112) this will become way easier to implement (as well as the removal of many more hard-coded values).

comment:9 Changed 5 years ago by poz2k4444

  • Cc cvervoorts@… removed
  • Owner changed from poz2k4444 to matze

comment:10 Changed 4 years ago by matze

  • Blocked By 3206 added

comment:11 Changed 4 years ago by matze

  • Cc fred added
  • Review URL(s) modified (diff)
  • Status changed from new to reviewing
  • Tester set to Unknown

comment:12 Changed 4 years ago by matze

  • Review URL(s) modified (diff)

comment:13 Changed 4 years ago by matze

  • Review URL(s) modified (diff)

comment:16 Changed 4 years ago by matze

  • Resolution set to fixed
  • Status changed from reviewing to closed
Note: See TracTickets for help on using tickets.