Opened 5 years ago

Closed 5 years ago

Last modified 5 years ago

#1230 closed defect (fixed)

Wrong Facebook/G+/Twitter icons on the first-run page

Reported by: trev Assignee: oleksandr
Priority: P2 Milestone: Adblock-Plus-for-Internet-Explorer-1.3
Module: Adblock-Plus-for-Internet-Explorer Keywords:
Cc: oleksandr Blocked By:
Blocking: Platform: Internet Explorer
Ready: yes Confidential: no
Tester: Verified working: no
Review URL(s):

http://codereview.adblockplus.org/5477003205541888/
http://codereview.adblockplus.org/5535282690523136/

Description

Environment

Adblock Plus for Internet Explorer 1.2

How to reproduce

  1. Install Adblock Plus for Internet Explorer 1.2
  2. Have a look at the sharing icons on the first-run page.

Observed behaviour

https://hg.adblockplus.org/adblockplusie/raw-file/b241d73f074d/html/static/img/social/facebook-old.png is being used as the Facebook icon. We stopped using that icon everywhere something like a year ago.

Expected behaviour

https://hg.adblockplus.org/adblockplusie/raw-file/b241d73f074d/html/static/img/social/facebook.png should be used as the Facebook icon. This icon is apparently being used on the settings page already.

Change History (5)

comment:1 Changed 5 years ago by oleksandr

  • Owner set to oleksandr

comment:2 Changed 5 years ago by oleksandr

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:3 Changed 5 years ago by fhd

  • Review URL(s) modified (diff)

Already pushed, but it broke the devbuilds: We need to remove the old icons from the installer, too. Added the review.

comment:4 Changed 5 years ago by fhd

  • Resolution set to fixed
  • Status changed from reviewing to closed

Second change pushed. Devbuilds are working again, closing.

comment:5 Changed 5 years ago by oleksandr

  • Milestone set to Adblock-Plus-for-Internet-Explorer-1.3
Note: See TracTickets for help on using tickets.