Opened 5 years ago

Closed 5 years ago

Last modified 5 years ago

#1231 closed defect (fixed)

video doesn't play with ABP for IE at http://www.foxsports.com/golf/story/tiger-woods-withdraws-from-ryder-cup-consideration-081314

Reported by: philll Assignee: sergz
Priority: P2 Milestone: Adblock-Plus-for-Internet-Explorer-1.3
Module: Adblock-Plus-for-Internet-Explorer Keywords:
Cc: oleksandr@…, arthur, serggzz@… Blocked By: #1265
Blocking: Platform: Internet Explorer
Ready: yes Confidential: no
Tester: Verified working: no
Review URL(s):

Description

Environment

Win 7 Enterprise
IE 11
ABP 1.2
Easylist
Acceptable ads enabled

How to reproduce

  1. Go to http://www.foxsports.com/golf/story/tiger-woods-withdraws-from-ryder-cup-consideration-081314

Observed behaviour

The video doesn't show up. Works fine with ABP for Chrome.

Expected behaviour

The video should be displayed and playing.

Change History (7)

comment:1 Changed 5 years ago by oleksandr

  • Cc oleksandr@… added
  • Ready set

comment:2 Changed 5 years ago by oleksandr

  • Blocked By 1265 added

comment:3 Changed 5 years ago by arthur

  • Cc arthur added

comment:4 Changed 5 years ago by sergz

  • Cc serggzz@… added
  • Owner set to sergz

The main trouble here is that we don't detect object-subrequest requests and their source now.

Here is one heuristic of detecting of object-subrequest request which works here and looks fragile (need more testing) and it actually fixes this bug.

But I would say it's only one small step. Even if detect that it's the object-subrequest request I have not managed yet the way to detect the issuer of the request. It could be important in some cases when the source is whitelisted and thus all subrequests are allowed as well. JIC, also take into account that there could be several embedded objects on the page and we should correctly find the exact issuer of the request.

Also one important point here is that fortunately for us Flash.ocx (my current version is 15.0.0.152) uses monikers to send the http requests, but it may use raw sockets as well and we won't be able to intersect such queries so easily.

comment:5 Changed 5 years ago by oleksandr

  • Resolution set to fixed
  • Status changed from new to closed

comment:6 Changed 5 years ago by oleksandr

While this was fixed, two follow-up issues have been filed: #1530 and #1531

comment:7 Changed 5 years ago by oleksandr

  • Milestone set to Adblock-Plus-for-Internet-Explorer-next
Note: See TracTickets for help on using tickets.