Opened 5 years ago

Closed 5 years ago

Last modified 5 years ago

#1232 closed change (fixed)

[Stop using ATL] Replace ATL::CSimpleArray with std::set

Reported by: eric@… Assignee: eric@…
Priority: P4 Milestone: Adblock-Plus-for-Internet-Explorer-1.3
Module: Adblock-Plus-for-Internet-Explorer Keywords:
Cc: trev Blocked By:
Blocking: #276 Platform: Internet Explorer
Ready: yes Confidential: no
Tester: Verified working: no
Review URL(s):

http://codereview.adblockplus.org/5712621990838272/

Description (last modified by eric@…)

Background

We use ATL::CSimpleArray.

What to change

Replace it with std::set.

Hints for testers

There's only one place where this data structure was used, and it involves the ABP icon in the status bar. Misbehavior in the affected code would involve the icon not appearing correctly, not responding, responding incorrectly, or other similar kinds of misbehavior.

Change History (9)

comment:1 Changed 5 years ago by eric@…

  • Summary changed from Replace ATL::CSimpleArray with std::set. to Replace ATL::CSimpleArray with std::set

comment:2 Changed 5 years ago by eric@…

  • Resolution set to fixed
  • Status changed from new to closed

comment:3 Changed 5 years ago by fhd

  • Priority changed from Unknown to P4
  • Ready set
  • Summary changed from Replace ATL::CSimpleArray with std::set to [Stop using ATL} Replace ATL::CSimpleArray with std::set

comment:4 Changed 5 years ago by fhd

  • Summary changed from [Stop using ATL} Replace ATL::CSimpleArray with std::set to [Stop using ATL] Replace ATL::CSimpleArray with std::set

comment:5 Changed 5 years ago by fhd

  • Review URL(s) modified (diff)

comment:6 Changed 5 years ago by trev

  • Cc trev added

Eric, could you please modify the description of this issue and add hints for testers? It is very non-obvious which functionality is affected by this issue.

comment:7 Changed 5 years ago by trev

  • Owner set to eric@…

comment:8 Changed 5 years ago by trev

  • Milestone set to Adblock-Plus-for-Internet-Explorer-next

This apparently landed with https://hg.adblockplus.org/adblockplusie/rev/cafe08d45329.

Eric, still waiting for you to update the description of this issue.

comment:9 Changed 5 years ago by eric@…

  • Description modified (diff)
Note: See TracTickets for help on using tickets.