Opened 5 years ago

Closed 5 years ago

Last modified 5 years ago

#1235 closed defect (fixed)

Adblock Plus entry in Control Panel has a generic installer icon

Reported by: Gingerbread Man Assignee: eric@…
Priority: P3 Milestone: Adblock-Plus-for-Internet-Explorer-1.4
Module: Adblock-Plus-for-Internet-Explorer Keywords:
Cc: Blocked By:
Blocking: Platform: Internet Explorer
Ready: yes Confidential: no
Tester: Verified working: no
Review URL(s):

http://codereview.adblockplus.org/4657627648753664/

Description

Environment

Windows XP SP3 • Adblock Plus 1.2

How to reproduce

  1. Open the Windows Control Panel, Add/Remove Programs section.

Observed behavior

The Adblock Plus entry has a generic installer icon.

Expected behavior

The Adblock Plus entry should have the ABP logo as its icon.

Change History (7)

comment:1 Changed 5 years ago by oleksandr

  • Ready set

comment:2 Changed 5 years ago by eric@…

  • Review URL(s) modified (diff)

comment:3 Changed 5 years ago by eric@…

The first review uses the existing "blocking.ico" icon file, which is the only appropriate icon in the source tree as of this writing.

When #1538 is ready, we should use a separate icon file for this resource that has multiple resolutions. A small icon is used in the line item within the listing, and a larger one appears at the bottom when the item is selected.

comment:4 Changed 5 years ago by eric@…

  • Status changed from new to reviewing

comment:5 Changed 5 years ago by eric@…

  • Owner set to eric@…

comment:6 Changed 5 years ago by eric@…

  • Resolution set to fixed
  • Status changed from reviewing to closed

comment:7 Changed 5 years ago by oleksandr

  • Milestone set to Adblock-Plus-for-Internet-Explorer-1.4
Note: See TracTickets for help on using tickets.