Opened 5 years ago

Closed 4 years ago

#1236 closed defect (fixed)

AdblockPlusEngine.exe and AdblockPlus32.dll metadata issues

Reported by: Gingerbread Man Assignee: eric@…
Priority: P3 Milestone: Adblock-Plus-for-Internet-Explorer-1.4
Module: Adblock-Plus-for-Internet-Explorer Keywords:
Cc: Blocked By:
Blocking: Platform: Internet Explorer
Ready: yes Confidential: no
Tester: Verified working: no
Review URL(s):

http://codereview.adblockplus.org/4533401491079168/

Description

Environment

Windows XP SP3 • Adblock Plus 1.2

How to reproduce

  1. Open the Adblock Plus installation folder in Windows Explorer.
  2. Right-click either file and choose Properties.
  3. Click the Version tab.

Observed behavior

  • The metadata for AdblockPlusEngine.exe and AdblockPlus32.dll says "Copyright: Copyright 2013".
  • The metadata for AdblockPlus32.dll says "Company: Adblock Plus".
  • AdblockPlusEngine.exe has no icon.

Expected behavior

  • The metadata for AdblockPlusEngine.exe and AdblockPlus32.dll should say something like "Copyright: © Eyeo GmbH. All rights reserved."
  • The metadata for AdblockPlus32.dll should say "Company: Eyeo GmbH"
  • AdblockPlusEngine.exe should have the ABP logo as its icon.

Attachments (1)

adblockplusengine_metadata.png (8.3 KB) - added by Gingerbread Man 5 years ago.
adblockplusengine_metadata.png

Download all attachments as: .zip

Change History (6)

Changed 5 years ago by Gingerbread Man

adblockplusengine_metadata.png

comment:1 Changed 5 years ago by oleksandr

  • Ready set

comment:2 Changed 4 years ago by eric@…

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:3 Changed 4 years ago by eric@…

  • Owner set to eric@…

comment:4 Changed 4 years ago by eric@…

Change set a3cfc6cc9a081309d184ecadb128740db0b33a7d (from the first review) changes the text in the metadata for the engine and the BHO.

Changing the icon requires a multiresolution icon. See #1538 for current progress on that front.

comment:5 Changed 4 years ago by oleksandr

  • Milestone set to Adblock-Plus-for-Internet-Explorer-1.4
  • Resolution set to fixed
  • Status changed from reviewing to closed
Note: See TracTickets for help on using tickets.