Opened 5 years ago

Closed 5 years ago

Last modified 4 years ago

#1241 closed defect (fixed)

Element hiding exceptions broken in Firefox 34

Reported by: trev Assignee: trev
Priority: P1 Milestone: Adblock-Plus-2.6.5-for-Firefox
Module: Adblock-Plus-for-Firefox Keywords:
Cc: Blocked By:
Blocking: Platform: Firefox
Ready: yes Confidential: no
Tester: Verified working: no
Review URL(s):

http://codereview.adblockplus.org/6019524214128640

Description

Environment

Adblock Plus 2.6.4.3857, Firefox 34.0a1 (nightly from 2014-08-15)

Background info

This was reported in https://bugzilla.mozilla.org/show_bug.cgi?id=1054162, this is a regression from https://bugzilla.mozilla.org/show_bug.cgi?id=1050049 landing. Apparently, the binding we apply to hidden elements needs bindToUntrustedContent='true' attribute.

How to reproduce

  1. Add filter rule ~heise.de##H2[style="height: 22px;"] to your custom filters in Adblock Plus filter preferences.
  2. Go to http://heise.de/

Observed behaviour

The headings of second-row articles are hidden by this rule.

Expected behaviour

The filter should have no effect on heise.de.

Change History (8)

comment:1 Changed 5 years ago by trev

  • Component changed from Unknown to Adblock-Plus-for-Firefox
  • Platform changed from Unknown to Firefox/Firefox Mobile
  • Priority changed from Unknown to P1
  • Ready set

comment:2 Changed 5 years ago by fanboy

Is this the same bug I'm seeing on dailymail.co.uk?

##.img-share
dailymail.co.uk#@#.img-share

dailymail seems to ignore the whitelist?

regression range;
http://ftp.mozilla.org/pub/mozilla.org/firefox/tinderbox-builds/mozilla-central-win32/
[DIR] 1407837722/ 12-Aug-2014 13:37 - good
[DIR] 1407853797/ 12-Aug-2014 16:54 - bad

comment:3 Changed 5 years ago by trev

Yes, same issue.

comment:4 Changed 5 years ago by trev

  • Owner set to trev

comment:5 Changed 5 years ago by trev

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:6 Changed 5 years ago by trev

  • Resolution set to fixed
  • Status changed from reviewing to closed

comment:7 Changed 5 years ago by trev

  • Milestone set to Adblock-Plus-for-Firefox-next

comment:8 Changed 4 years ago by philll

  • Platform changed from Firefox/Firefox Mobile to Firefox

Made Firefox and Firefox mobile available as seperate platforms.

Note: See TracTickets for help on using tickets.