Opened 6 years ago

Closed 5 years ago

#125 closed defect (fixed)

Get rid of ExtractDomain(), let libadblockplus do it

Reported by: fhd Assignee: oleksandr
Priority: P3 Milestone: Adblock-Plus-1.2-for-Internet-Explorer
Module: Adblock-Plus-for-Internet-Explorer Keywords: ie_devbuild_1.2
Cc: Blocked By:
Blocking: Platform:
Ready: yes Confidential: no
Tester: Verified working: no
Review URL(s):

http://codereview.adblockplus.org/5652794446970880/

Description

This should be done anyway as a clean up, but apparently it currently causes issues on some sites, e.g. ebay.pl.

Change History (10)

comment:1 Changed 6 years ago by fhd

  • Status changed from new to accepted

comment:2 Changed 6 years ago by philll

  • Status changed from accepted to new

comment:3 Changed 6 years ago by oleksandr

  • Ready unset
  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:4 Changed 6 years ago by trev

  • Owner set to oleksandr
  • Status changed from reviewing to assigned

comment:5 Changed 6 years ago by trev

  • Status changed from assigned to reviewing

comment:6 Changed 6 years ago by philll

As there is already a review ongoing, could you please get this issue in an adequate and sufficient form and then set it to ready?

comment:7 Changed 5 years ago by fhd

  • Ready set

Set it to ready. The description is good enough here, we have a review already after all.

comment:8 Changed 5 years ago by oleksandr

  • Milestone set to Adblock-Plus-for-Internet-Explorer-next

comment:9 Changed 5 years ago by philll

  • Keywords ie_devbuild_1.2 added

comment:10 Changed 5 years ago by oleksandr

  • Resolution set to fixed
  • Status changed from reviewing to closed
Note: See TracTickets for help on using tickets.