Opened 5 years ago

Closed 5 years ago

Last modified 5 years ago

#1253 closed defect (duplicate)

ABP Firefox is able to block ads on http://www.london24.com/ but not Chrome ABP

Reported by: passbrains Assignee:
Priority: P3 Milestone:
Module: Platform Keywords:
Cc: mapx, arthur, sebastian Blocked By:
Blocking: Platform: Chrome
Ready: no Confidential: no
Tester: Verified working: no
Review URL(s):

Description (last modified by mapx)

Adapted from https://www.passbrains.com/dashboard/view-ticket.php?ticket_no=ACH-32

Environment

Windows 7 64bit Chrome English
ABP version 1.8.3.1204

How to reproduce

  1. Install ABP for Chrome and open page http://www.london24.com/news/crime/met_spied_on_relatives_of_jean_charles_de_menezes_claims_family_1_3698056
  2. Check Promoted Stories section.

Observed behaviour

ABP Chrome is not blocking ads in Promoted Stories links.

Expected behaviour

ABP Chrome should block these as done by Firefox ABP

Attachments (2)

1618_1406206891_Chrome.PNG (500.6 KB) - added by passbrains 5 years ago.
1618_1406206891_Firefox.PNG (396.1 KB) - added by passbrains 5 years ago.

Download all attachments as: .zip

Change History (8)

Changed 5 years ago by passbrains

Changed 5 years ago by passbrains

comment:1 Changed 5 years ago by passbrains

1 - 27 Jul 2014 12:06:53 posted by Abhinav Sejpal
ABP FF is blocking side ads. I have applied easy list filter only (No extra changes).

comment:2 Changed 5 years ago by mapx

  • Cc mapx added
  • Component changed from Unknown to Platform
  • Description modified (diff)
  • Priority changed from Unknown to P3

could be the same reason as for 242 ticket ?
https://issues.adblockplus.org/ticket/242

comment:3 Changed 5 years ago by sebastian

  • Cc arthur sebastian added

The HTML that outbrain (the widget used here) generates for Chrome looks kinda different from the HTML it generates for Firefox. So I assume that it isn't a bug in Adblock Plus for Chrome, but that the filters in EasyList only address the Firefox version of that website.

comment:4 Changed 5 years ago by arthur

I see this container <div class="item-container ob-recIdx-3 item-container-ad "> which should actually be hidden by ##.item-container-ad but isn't. So I assume it's an ABP/Chrome issue.

comment:5 follow-up: Changed 5 years ago by sebastian

  • Resolution set to duplicate
  • Status changed from new to closed

The style we inject is overridden by following rule, which is defined by an inline style tag:

.AR_4 .ob_container_recs .item-container {
  display: inline-block !important;

  ...
}

So it is indeed the same issue as #242, as mapx suspected.

However, is there any reason why EasyList is using element hiding, instead just blocking outbrain's script (widgets.outbrain.com/outbrain.js)?

Version 2, edited 5 years ago by sebastian (previous) (next) (diff)

comment:6 in reply to: ↑ 5 Changed 5 years ago by arthur

Replying to sebastian:

However, is there any reason why EasyList is using element hiding, instead just blocking outbrain's script?

Yes, Outbrain also provides first-party recommendations on sites. Blocking that script would remove those.

Added a specific hiding filter: https://hg.adblockplus.org/easylist/rev/96e8b87ae7b8

Note: See TracTickets for help on using tickets.