Opened 5 years ago

Closed 5 years ago

Last modified 5 years ago

#1255 closed defect (duplicate)

Social buttons broken on first-run page when activating social blocking list

Reported by: arthur Assignee:
Priority: P2 Milestone:
Module: Adblock-Plus-for-Firefox Keywords:
Cc: Blocked By:
Blocking: Platform: Firefox
Ready: yes Confidential: no
Tester: Verified working: no
Review URL(s):

Description

Environment

Firefox 31
Adblock Plus 2.6.4.3859

How to reproduce

  1. Open the firs-run page in Firefox by going to chrome://adblockplus/content/ui/firstRun.html
  2. Activate the social blocking list if necessary
  3. Click either the Google Plus or Twitter sharing button

Observed behaviour

The sharing overlay appears but the buttons are blocked. Sharing/liking isn't possible.

Expected behaviour

When clicking on the share buttons after activating the social blocking list, the user should be taken to the respective social media page of Adblock Plus like with the Facebook botton.

This is also happening in Chrome.

Via Passbrains: https://www.passbrains.com/dashboard/view-ticket.php?ticket_no=ARE-21

Change History (4)

comment:1 in reply to: ↑ description ; follow-up: Changed 5 years ago by barbaz

I can confirm that this happens with latest dev build of ABP on latest SeaMonkey release. But...

Replying to arthur:

The sharing overlay appears but the buttons are blocked. Sharing/liking isn't possible.

Isn't that the whole point of a social *blocking* list?
I would think that the issue here is that the Facebook button on the first-run page is *not* getting blocked - and that would be a filterlist issue, not an ABP issue.

comment:2 in reply to: ↑ 1 Changed 5 years ago by arthur

Replying to barbaz:

I would think that the issue here is that the Facebook button on the first-run page is *not* getting blocked - and that would be a filterlist issue, not an ABP issue.

When a user activates the social blocking list, it blocks all like, share, follow buttons and such that (could potentially) track you. That's why you don't see those buttons in the sharing overlay. Instead of the overlay the social media buttons should simply link to the social media pages so the user can go there and like/follow/+1 that page if (s)he still wants to. This is currently only working for the Facebook button.

comment:3 Changed 5 years ago by philll

  • Resolution set to duplicate
  • Status changed from new to closed

See #1223

comment:4 Changed 5 years ago by philll

  • Platform changed from Firefox/Firefox Mobile to Firefox

Made Firefox and Firefox mobile available as seperate platforms.

Note: See TracTickets for help on using tickets.