Opened 5 years ago

Closed 4 years ago

#1256 closed defect (worksforme)

ABP does not work with Electrolysis enabled

Reported by: The 8472 Assignee:
Priority: Unknown Milestone:
Module: Unknown Keywords:
Cc: Blocked By:
Blocking: Platform: Firefox
Ready: yes Confidential: no
Tester: Unknown Verified working: no
Review URL(s):

Description

Since ABP is listed on http://arewee10syet.com/ as working and it doesn't for me this might be something new.

Environment

64bit linux
FF Nightly 34.0a1 (2014-08-21)
Adblock Plus 2.6.4.3859
No filter lists enabled

How to reproduce

  1. set browser.tabs.remote = true, browser.tabs.remote.autostart = true
  2. restart FF
  3. open the "blockable items" view
  4. navigate to any website that has blockable content

Observed behaviour

No blockable items get listed.

Exception on the browser console:
TypeError: invalid 'in' operand wnd in contentPolicy.js:700

Expected behaviour

Blockable items should show up.

Change History (7)

comment:1 Changed 5 years ago by philll

  • Platform changed from Unknown to Firefox/Firefox Mobile
  • Ready set

At http://test.de, I am sort of randomly getting one blockable item shown, which is http://www.test.de/img/general/header/bg_my-test-nav;v63543085440.png or none at all. When reloading or trying in a new tab, I am getting loads of blockable items.

comment:2 Changed 5 years ago by The 8472

ABP 2.6.4.3859 is the current development build, have you tested with that?

comment:3 Changed 5 years ago by Gingerbread Man

Firefox 35.0a1 (2014-09-11) • Adblock Plus 2.6.4.3862 • Element Hiding Helper 1.3.0.470

  1. I didn't touch about:config. There was a prompt in a doorhanger notification asking me to enable e10s. I accepted and Firefox restarted.
  2. My browser console is showing something else:
    Error: unable to modify interposed property content sidebar.js:88
    TypeError: target.gBrowser is undefined RemoteAddonsParent.jsm:639
    

comment:4 Changed 5 years ago by Gingerbread Man

Additionally, blocking doesn't work in on-demand e10s windows.

  1. If you've enabled e10s by default, first turn it off under Options → General, then restart Nightly.
  2. Disable "Allow some non-intrusive advertising".
  3. Click the ≡ Menu Button and choose New E10s Window.
  4. Click the ≡ Menu Button and choose Developer, then Browser Console.
  5. Make sure every subsection under the Net button is enabled, then click the Clear button.
  6. Go to http://forums.mozillazine.org/viewtopic.php?p=13763633#p13763633
  7. In the Browser Console search box, type googlesyndication.com. You should see the requests going out to the Google ad server.

Element hiding seems to work fine though, using the following filter as a test:

forums.mozillazine.org##*

comment:5 Changed 5 years ago by Gingerbread Man

The First Run page is broken, as reported at https://adblockplus.org/forum/viewtopic.php?f=1&t=25292

Nightly 35.0a1 (2014-09-28) • Adblock Plus 2.6.4.3867

  • The "strict guidelines", "disable" and "Contributor Credits" links aren't clickable. They don't even have the typical hand cursor; the text selection I-beam is displayed instead.
  • The "donate" button has the correct hand cursor, but again nothing happens when it's clicked (in contrast, the social media links seem to work fine).
  • The various suggested subscriptions incorrectly display an "ON" switch, though I'm not subscribed to the respective lists. Clicking the switch does nothing.

When opening the First Run page, the Browser Console shows

TypeError: require(...) is undefined utils.js:36
TypeError: require(...) is undefined firstRun.js:46

comment:6 Changed 5 years ago by philll

  • Platform changed from Firefox/Firefox Mobile to Firefox

Made Firefox and Firefox mobile available as seperate platforms.

comment:7 Changed 4 years ago by trev

  • Resolution set to worksforme
  • Status changed from new to closed
  • Tester set to Unknown

This particular issue went away a while ago, I'm not sure what exactly fixed it. There are still some known issues with E10S, I'm making sure these are files and tagged with the e10s keyword.

Note: See TracTickets for help on using tickets.