Opened 5 years ago

Closed 5 years ago

#1258 closed defect (fixed)

Ads in YouTube's HTML5 player aren't blocked

Reported by: sebastian Assignee: sebastian
Priority: P1 Milestone: Adblock-Plus-1.8.4-for-Chrome-Opera-Safari
Module: Platform Keywords:
Cc: Blocked By: #1259
Blocking: Platform: Safari
Ready: yes Confidential: no
Tester: Verified working: no
Review URL(s):

http://codereview.adblockplus.org/5607308285444096

Description

How to reproduce

  1. Go to youtube.com
  2. Watch any video
  3. Make sure you got the HTML5 player (should be the default with Safari 7)

Observed behaviour

You see preroll and/or overlay ads in the video.

Expected behaviour

All ads on YouTube, including those shown with the HTML5 player, should be blocked.

Change History (5)

comment:1 Changed 5 years ago by sebastian

The XMLHttpRequest loading those ads is blocked by EasyList. But unfortunately those requests can't be blocked on Safari. However, it is possible to block those ads, by modifying ytplayer.config.args, similar to how we rewrite falshvars.

comment:2 Changed 5 years ago by sebastian

  • Blocked By 1259 added

comment:3 Changed 5 years ago by sebastian

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:4 Changed 5 years ago by sebastian

  • Milestone set to Adblock-Plus-for-Chrome-Opera-Safari-next
  • Priority changed from P2 to P1

comment:5 Changed 5 years ago by sebastian

  • Resolution set to fixed
  • Status changed from reviewing to closed
Note: See TracTickets for help on using tickets.