Opened 5 years ago

Closed 5 years ago

#1259 closed change (fixed)

Block while checking whether ABP is disabled on YouTube

Reported by: sebastian Assignee: sebastian
Priority: P1 Milestone: Adblock-Plus-1.8.4-for-Chrome-Opera-Safari
Module: Platform Keywords:
Cc: Blocked By:
Blocking: #1258 Platform: Safari
Ready: yes Confidential: no
Tester: Verified working: no
Review URL(s):

http://codereview.adblockplus.org/4757413714460672

Description

Background

We use asynchronous messaging to check whether Adblock Plus is disabled before modifying the page in order to block video ads on YouTube. While waiting for the response YouTube's JavaScript already runs.

But in order to fix #1258 we have to define a property on the window object, before YouTube's JavaScript runs.

It is the same with the code disabling the history API, which we currently run no matter whether Adblock Plus is disabled on YouTube.

What to change

Use synchronous messaging to block execution while checking whether Adblock Plus is disabled on YouTube.

Change History (3)

comment:1 Changed 5 years ago by sebastian

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:2 Changed 5 years ago by sebastian

  • Milestone set to Adblock-Plus-for-Chrome-Opera-Safari-next
  • Priority changed from P2 to P1

comment:3 Changed 5 years ago by sebastian

  • Resolution set to fixed
  • Status changed from reviewing to closed
Note: See TracTickets for help on using tickets.