Opened 5 years ago

Closed 22 months ago

#1263 closed defect (rejected)

Custom filter don't work anymore after ABP update

Reported by: sebastian Assignee:
Priority: P4 Milestone:
Module: Adblock-Plus-for-Firefox Keywords:
Cc: fhd, mapx Blocked By:
Blocking: Platform: Firefox
Ready: no Confidential: no
Tester: Verified working: no
Review URL(s):

Attachments (1)

IMG_20140824_164228.jpg (2.2 MB) - added by sebastian 5 years ago.

Download all attachments as: .zip

Change History (9)

Changed 5 years ago by sebastian

comment:1 Changed 5 years ago by sebastian

  • Cc fhd added
  • Description modified (diff)

comment:2 Changed 5 years ago by mapx

  • Cc mapx added

comment:3 Changed 5 years ago by philll

  • Description modified (diff)

Avoided the image to spam the timeline. Please provide more details for this issue.

comment:4 follow-ups: Changed 5 years ago by fhd

This was a real life bug report. The problem description was, roughly: "My custom filters on gmx.net don't work anymore since the last Adblock Plus or Firefox update."

Does sound like a regression.

comment:5 in reply to: ↑ 4 Changed 5 years ago by Gingerbread Man

Replying to sebastian:

see attachment:IMG_20140824_164228.jpg

That is hilarious

comment:6 in reply to: ↑ 4 Changed 5 years ago by Gingerbread Man

Replying to sebastian:

see attachment:IMG_20140824_164228.jpg

That is hilarious.

Replying to fhd:

Does sound like a regression.

Those are simplified hiding filters. Even if you didn't remove support for them intentionally, why would you want to spend any time re-adding support for them? Wladimir planned to remove support for simplified syntax as far back as April 2009. Even the documentation warns about it.

The user should use CSS selectors, like so:

www.gmx.net##div[class="news content"]
www.gmx.net##div.r2
www.gmx.net##div.r1
logout.gmx.uimserv.net##div#innerContent

Specifying the element type for that last one is probably redundant, since id attributes are supposed to be unique:

logout.gmx.uimserv.net###innerContent

comment:7 Changed 4 years ago by philll

  • Platform changed from Firefox/Firefox Mobile to Firefox

Made Firefox and Firefox mobile available as seperate platforms.

comment:8 Changed 22 months ago by trev

  • Resolution set to rejected
  • Status changed from new to closed

Mass-closing all bugs in Adblock Plus for Firefox module, the codebase of Adblock Plus 3.0 belongs into Platform and User-Interface modules. Old bugs are unlikely to still apply.

Note: See TracTickets for help on using tickets.