Opened 5 years ago

Closed 5 years ago

Last modified 5 years ago

#1264 closed change (fixed)

Figure out the best way to block subdomain requests

Reported by: oleksandr Assignee: sergz
Priority: P2 Milestone: Adblock-Plus-for-Internet-Explorer-1.3
Module: Adblock-Plus-for-Internet-Explorer Keywords:
Cc: oleksandr, mapx Blocked By:
Blocking: #1193, #1238, #1246 Platform: Internet Explorer
Ready: yes Confidential: no
Tester: Verified working: no
Review URL(s):

http://codereview.adblockplus.org/6299667012780032/

Description

Background

When we block subdomain requests we need to notify IE that the request is going to be blocked. Currently there were 3 tries of that:

  • If we just report the request a failed IE will display the ""Internet Explorer cannot display this page" in place of a source iframe
  • If we report that the request is "redirecting", some events will not fire on the DOM, and bugs like #1193 appear.
  • If we just report that the request is ok, IE would still make the request, though result might not be shown.

What to change

We need to figure out a correct way of blocking these requests.

Change History (8)

comment:1 Changed 5 years ago by oleksandr

  • Cc oleksandr@… added

comment:2 Changed 5 years ago by mapx

  • Cc oleksandr mapx added; oleksandr@… removed

comment:3 Changed 5 years ago by oleksandr

  • Milestone Adblock-Plus-for-Internet-Explorer-next deleted

comment:4 Changed 5 years ago by oleksandr

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:5 Changed 5 years ago by sergz

  • Review URL(s) modified (diff)

comment:6 Changed 5 years ago by oleksandr

  • Priority changed from P1 to P2

comment:7 Changed 5 years ago by oleksandr

  • Resolution set to fixed
  • Status changed from reviewing to closed

comment:8 Changed 5 years ago by oleksandr

  • Milestone set to Adblock-Plus-for-Internet-Explorer-next
Note: See TracTickets for help on using tickets.