Opened 5 years ago

Closed 5 years ago

#1268 closed defect (fixed)

Options page isn't opened correctly when using incognito window

Reported by: sebastian Assignee: sebastian
Priority: P3 Milestone: Adblock-Plus-1.8.8-for-Chrome-Opera-Safari
Module: Platform Keywords:
Cc: Blocked By:
Blocking: Platform: Chrome
Ready: yes Confidential: no
Tester: Verified working: no
Review URL(s):

http://codereview.adblockplus.org/6622721232338944

Description

Environment

Chrome 36 / Linux

How to reproduce

  1. Open an incognito window (Ctrl + Shift + N)
  2. Click on the ABP logo in order to open the bubble UI
  3. Click on "Options" (several times)

Observed behaviour

The options page is opened in a different (non-incognito) window. So far this is the expected behavior and the only possible way. However...

  1. The window in which the options page opens doesn't get focused.
  2. When you click on "Options" again, another tab is created, instead switching to the tab with the previously opened options page.

Expected behaviour

The options page should be opened via the bubble UI, in the same fashion Chrome does it by itself (e.g. when using the context menu of the ABP icon).

That means in case you are in an incognito window, the options page should be opened in a non-incognito window focusing that window. And if the window, the options page would be shown in, already has a tab with the options page, that tab should be focused instead creating a new one.

Change History (3)

comment:1 Changed 5 years ago by sebastian

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:2 Changed 5 years ago by sebastian

  • Review URL(s) modified (diff)

comment:3 Changed 5 years ago by sebastian

  • Milestone set to Adblock-Plus-for-Chrome-Opera-Safari-next
  • Resolution set to fixed
  • Review URL(s) modified (diff)
  • Status changed from reviewing to closed
Note: See TracTickets for help on using tickets.