Opened 5 years ago

Last modified 5 years ago

#1273 closed defect

WebKit misoptimazions strike again: Overridden getters are called on Safari 8 — at Initial Version

Reported by: sebastian Assignee: sebastian
Priority: P1 Milestone: Adblock-Plus-1.8.4-for-Chrome-Opera-Safari
Module: Platform Keywords:
Cc: Blocked By:
Blocking: Platform: Safari
Ready: yes Confidential: no
Tester: Verified working: no
Review URL(s):

http://codereview.adblockplus.org/6055266931965952

Description

Environment

Safari 8 / Mac OS X Yosemite

Observed behaviour

Randomly, some ads aren't blocked, while the log of the global page is flooded with errors indicating that the readonly properties RegExpFilter.regexp and ActiveFilter.domains are attempted to be redefined.

The reason is WebKit bug 132872, which we previously worked around with #419. However it seems that Safari 8 does more aggressive optimazions, rendering our current workaround insufficient.

Expected behaviour

Ads should be always blocked when Adblock Plus is active. No unhandled JavaScript errors should occur in the global page.

Change History (0)

Note: See TracTickets for help on using tickets.