Changes between Initial Version and Version 6 of Ticket #1285


Ignore:
Timestamp:
09/02/2014 01:49:52 PM (5 years ago)
Author:
fhd
Comment:

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #1285

    • Property Priority changed from P3 to P2
  • Ticket #1285 – Description

    initial v6  
    11=== Background === 
    2 Libadblockplus is currently running regular update checks for the application (with data from ''AppInfo'') in the background. We've added this for practical reasons: Since all of our own Libadblockplus clients (Android and IE) need update functionality. However, other Libadblockplus clients do not necessarily want to use this update mechanism, so it should be possible to disable it. 
     2Libadblockplus is currently running regular update checks for the application (with data from `AppInfo`) in the background. We've added this for practical reasons: Since all of our own Libadblockplus clients (Android and IE) need update functionality. However, other Libadblockplus clients do not necessarily want to use this update mechanism, so it should be enabled explicitly. 
    33 
    44=== What to change === 
    5 The easiest option would be to add a method that disables update checks to ''FilterEngine''. 
    6  
    7 However, it would be cleaner to move the update functionality out of ''FilterEngine'' and into a dedicated component, which clients could then use explicitly. If we don't do this right away, we should file a follow-up issue for it. 
     51. Remove the `update_url_release` and `devbuild_update_url` prefs we set in Libadblockplus. 
     62. Remove `AppInfo::developmentBuild` - Libadblockplus doesn't need to know anymore. 
     73. Add a setter for the update URL to `FilterEngine`. Update checks should only happen if an URL has been set here, i.e. not by default.