Opened 5 years ago

Closed 5 years ago

#1286 closed change (fixed)

Add a content type enum

Reported by: fhd Assignee: hexene
Priority: P4 Milestone:
Module: Libadblockplus Keywords:
Cc: trev Blocked By:
Blocking: Platform: Unknown
Ready: yes Confidential: no
Tester: Verified working: no
Review URL(s):

https://github.com/adblockplus/libadblockplus/pull/1

Description

Background

FilterEngine::Matches currently gets contentType as a string. Since there's a fixed list of supported content types, it should rather be an enum.

What to change

Create a ContentType enum and use it in FilterEngine::Matches.

Change History (3)

comment:1 Changed 5 years ago by fhd

  • Owner set to hexene

comment:2 Changed 5 years ago by trev

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:3 Changed 5 years ago by fhd

  • Resolution set to fixed
  • Status changed from reviewing to closed
Note: See TracTickets for help on using tickets.