Opened on 08/29/2014 at 03:32:49 PM

Closed on 08/30/2014 at 10:29:08 AM

#1287 closed change (fixed)

Use window.location instead document.location

Reported by: sebastian Assignee: sebastian
Priority: P4 Milestone: Adblock-Plus-1.8.4-for-Chrome-Opera-Safari
Module: Platform Keywords:
Cc: Blocked By:
Blocking: Platform: Unknown
Ready: yes Confidential: no
Tester: Verified working: no
Review URL(s):



document.location was originally meant to be a string representing the complete URL. Despite in modern browsers it is just an alias for window.location, we should explicitly use window.location to avoid confusion.

What to change

Get rid of code using document.location in favor of window.location.

Attachments (0)

Change History (3)

comment:1 Changed on 08/29/2014 at 03:33:54 PM by sebastian

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:2 Changed on 08/29/2014 at 03:34:05 PM by sebastian

  • Ready set

comment:3 Changed on 08/30/2014 at 10:29:08 AM by sebastian

  • Milestone set to Adblock-Plus-for-Chrome-Opera-Safari-next
  • Resolution set to fixed
  • Status changed from reviewing to closed

Add Comment

Modify Ticket

Change Properties
as closed .
The resolution will be deleted. Next status will be 'reopened'.
to The owner will be changed from sebastian.
Note: See TracTickets for help on using tickets.