Opened 5 years ago

Last modified 5 years ago

#1290 closed defect

Stylesheets aren't injected with Shadow DOM anymore on Chrome 37 — at Initial Version

Reported by: sebastian Assignee: sebastian
Priority: P2 Milestone: Adblock-Plus-1.8.5-for-Chrome-Opera-Safari
Module: Platform Keywords:
Cc: Blocked By:
Blocking: Platform: Chrome
Ready: yes Confidential: no
Tester: Verified working: no
Review URL(s):

http://codereview.adblockplus.org/5978149049335808

Description

Environment

Chrome 37

How to reproduce

  1. Visit any website
  2. Inspect the page (Ctrl + Shift + I)

Observed behaviour

You see the stylesheet Adblock Plus injected into the light DOM, bringing back issues like #309 and #369.

That is because since Chrome 37 there is no webkitCreateShadowRoot anymore. However, the un-prefixed createShadowRoot (added in Chrome 35) isn't supported by Adblock Plus yet.

Expected behaviour

The stylesheet should be injected with the Shadow DOM, hiding it from the website's JavaScript.

Change History (0)

Note: See TracTickets for help on using tickets.