Opened 5 years ago

Closed 4 years ago

#1292 closed defect (fixed)

Adapt style of donate and share sections on first-run page for smaller screens

Reported by: passbrains Assignee: greiner
Priority: P3 Milestone:
Module: User-Interface Keywords: goodfirstbug
Cc: manvel@… Blocked By:
Blocking: Platform: Firefox
Ready: yes Confidential: no
Tester: Unknown Verified working: no
Review URL(s):

https://codereview.adblockplus.org/29329048/

Description (last modified by greiner)

Adapted from https://www.passbrains.com/dashboard/view-ticket.php?ticket_no=AFI-14

Environment

Sony Ericsson Xperia T Android 4.3 Jelly Bean
ABP version 2.6.4.3852

How to reproduce

Firefox 31.0

  1. Install Firefox Mobile Plugin
  2. An ABP successfully installed page will be displayed
  3. Check the two dotted lines near the donate and share section

Another way of reproduction could be:

  1. Open first run page of ABP from Firefox for Desktop "chrome://adblockplus/content/ui/firstRun.html"
  2. resize the browser window so the "Tell your friends" section will get under "Support our project"

Observed behaviour

Left border is missing the lower half, right one is broken

Expected behaviour

Instead of the vertical borders there should be a horizontal border with the same style between the two sections.

What to change

On smaller screens i.e. width < 970px (760px maximum width + 2 * 100px padding + 10px extra)

  • hide the vertical borders of the donate and share section
  • make the two sections display: block to ensure that they're aligned vertically
  • add bottom border with the same styles as the vertical ones to donate section and include 20px space between section and border

Attachments (1)

3602_1406352835_Screenshot_2014-07-26-13-17-47.JPG (106.2 KB) - added by passbrains 5 years ago.

Download all attachments as: .zip

Change History (13)

comment:1 Changed 5 years ago by saroyanm

  • Component changed from Unknown to Adblock-Plus-for-Firefox
  • Description modified (diff)
  • Summary changed from ABP successfully installed page dotted lines are missing and broken to ABP First run page dotted lines are missing and broken

comment:2 Changed 5 years ago by saroyanm

  • Ready set

comment:3 Changed 5 years ago by saroyanm

  • Cc manvel@… added

comment:4 Changed 5 years ago by greiner

  • Component changed from Adblock-Plus-for-Firefox to User-Interface
  • Priority changed from Unknown to P3
  • Summary changed from ABP First run page dotted lines are missing and broken to Vertical lines on first-run page are oddly positioned on smaller screens

One solution to this would be to hide the vertical lines on small enough screens and instead show a horizontal line between the donate and the share block.

comment:5 Changed 5 years ago by greiner

  • Description modified (diff)

comment:6 Changed 5 years ago by greiner

  • Keywords goodfirstbug added
  • Summary changed from Vertical lines on first-run page are oddly positioned on smaller screens to Adapt style of donate and share sections on first-run page for smaller screens

comment:7 Changed 5 years ago by greiner

  • Blocking 2018 added

comment:8 Changed 5 years ago by philll

  • Platform changed from Firefox/Firefox Mobile to Firefox

Made Firefox and Firefox mobile available as seperate platforms.

comment:9 Changed 4 years ago by greiner

  • Blocking 2018 removed

comment:10 Changed 4 years ago by greiner

  • Owner set to greiner
  • Tester set to Unknown

comment:11 Changed 4 years ago by greiner

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:12 Changed 4 years ago by greiner

  • Resolution set to fixed
  • Status changed from reviewing to closed
Note: See TracTickets for help on using tickets.