Changes between Initial Version and Version 4 of Ticket #1296


Ignore:
Timestamp:
09/02/2014 01:25:59 PM (5 years ago)
Author:
fhd
Comment:

Yeah sure, I was sure I had changed this here...

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #1296

    • Property Ready set
    • Property Cc trev added
    • Property Summary changed from Add setters for the init and updateAvailable events to Add setters for the updateAvailable event
  • Ticket #1296 – Description

    initial v4  
    11=== Background === 
    2 ''FilterEngine'' currently throws three events that clients can react to: ''init'', ''filterChange'' and ''updateAvailable''. 
     2''FilterEngine'' currently throws two events that clients can react to: ''filterChange'' and ''updateAvailable''. 
    33 
    4 While there's ''FilterEngine::SetFilterChangeCallback'' to register a callback for that event, handlers for ''init'' and ''updateAvailable'' need to be registered manually via ''JsEngine::SetEventCallback''. 
     4While there's ''FilterEngine::SetFilterChangeCallback'' to register a callback for that event, handlers for ''updateAvailable'' need to be registered manually via ''JsEngine::SetEventCallback''. 
    55 
    6 The main problem with this is that users of Libadblockplus won't be aware that they can handle ''init'' and ''updateAvailable'' events, and at least the latter is something our own clients should use. 
     6The main problem with this is that users of Libadblockplus won't be aware that they can handle ''updateAvailable'' events, and at least the latter is something our own clients should use. 
    77 
    88=== What to change === 
    9 Add methods for adding and removing callbacks for the ''init'' and ''updateAvailable'' events to ''FilterEngine''. 
     9Add methods for adding and removing callbacks for the ''updateAvailable'' event to ''FilterEngine''.