Opened 6 years ago

Last modified 5 years ago

#1296 closed change

Add setters for the init and updateAvailable events — at Initial Version

Reported by: fhd Assignee:
Priority: P2 Milestone:
Module: Libadblockplus Keywords:
Cc: trev Blocked By:
Blocking: Platform: Unknown
Ready: yes Confidential: no
Tester: Verified working: no
Review URL(s):

http://codereview.adblockplus.org/4578638519336960/

Description

Background

FilterEngine currently throws three events that clients can react to: init, filterChange and updateAvailable.

While there's FilterEngine::SetFilterChangeCallback to register a callback for that event, handlers for init and updateAvailable need to be registered manually via JsEngine::SetEventCallback.

The main problem with this is that users of Libadblockplus won't be aware that they can handle init and updateAvailable events, and at least the latter is something our own clients should use.

What to change

Add methods for adding and removing callbacks for the init and updateAvailable events to FilterEngine.

Change History (0)

Note: See TracTickets for help on using tickets.